mac/dialog: refactoring and additions

[Akemi]

some dialog refactoring and additions, to make integrations with #15845 easier and prevent code duplications. needs a followup commit for #15845.

also shamelessly stole some ideas from @kasper93.

[github-actions]

Download the artifacts for this pull request:

Windows

• mpv-i686-w64-mingw32
• mpv-x86_64-w64-mingw32
• mpv-x86_64-windows-msvc

macOS

• mpv-macos-13-intel
• mpv-macos-14-arm
• mpv-macos-15-arm

[kasper93]

Not much to say, looks ok. I'm mostly interested how will it work when using mp_file_dialog_get_files, but this is next step.

[Akemi]

@kasper93 just a heads up, an initial implementation based on your PR including the changes from here. Akemi@813f53d

i am not sure what the assert equivalent would be. following is only evaluated on -Onone builds.

assert(retCount < 1 || ret != nil)

[kasper93]

@kasper93 just a heads up, an initial implementation based on your PR including the changes from here. Akemi@813f53d

Thanks!

i am not sure what the assert equivalent would be. following is only evaluated on -Onone builds.

assert(retCount < 1 || ret != nil)

You can skip it. It's not important. It was just a check.

What I aimed at is that. We return NULL if there is no selection and not NULL if there is at least one selection. To avoid cases where we return empty list (list with terminator only), which is valid, but I didn't want that.

[Akemi]

i see, that case should be handled by the guard that returns nil when the array is nil (the helper functions never return an empty array).

[kasper93]

I will cherry-pick your commit to my branch, after this PR is merged.

[hooke007]

@kasper93 I guess my previous question was flooded in the arguments of PR#15845. So I post it here. Do you have the plan to add the similar simple dialog for urls On Windows too?

[kasper93]

@kasper93 I guess my previous question was flooded in the arguments of PR#15845. So I post it here. Do you have the plan to add the similar simple dialog for urls On Windows too?

No. We want standard file selection dialog. We won't implement custom dialog to input strings or anything like that. Windows doesn't provide standard dialog that would provide what you want. Of course it is easy to make such dialog, it's not something that we want.

For url you can just paste directly and it will open it.