Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mrc 4694 : Prettier Setup #203

Merged
merged 8 commits into from
Nov 22, 2023
Merged

Mrc 4694 : Prettier Setup #203

merged 8 commits into from
Nov 22, 2023

Conversation

absternator
Copy link
Collaborator

@absternator absternator commented Nov 14, 2023

Setup prettier + run on files (frontend)

Note: Files changes as below, rest are running formttiing

  • prettierrc
  • eslintrc
  • package*
  • test.yaml
  • vscode/settings.json added

Note: in dev environment ensure default formatter is prettier

Copy link
Contributor

@EmmaLRussell EmmaLRussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me. Prettier plugin seems to come bundled with IntelliJ, so it's just a case of enabling format on save for those using IJ.

We could configure and update for the backend too - but let's do that in another branch!

Copy link
Collaborator

@M-Kusumgar M-Kusumgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for the delay! looks good to me, you may want to resolve the conflicts though before you merge!

Copy link

codecov bot commented Nov 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (affa851) 99.97% compared to head (669f8b7) 99.97%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #203   +/-   ##
=======================================
  Coverage   99.97%   99.97%           
=======================================
  Files         157      157           
  Lines        3969     3990   +21     
  Branches      603      595    -8     
=======================================
+ Hits         3968     3989   +21     
  Misses          1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@absternator absternator merged commit b47d862 into main Nov 22, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants