Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NodeBuilder: More docs. #30038

Merged
merged 2 commits into from
Dec 5, 2024
Merged

NodeBuilder: More docs. #30038

merged 2 commits into from
Dec 5, 2024

Conversation

sunag
Copy link
Collaborator

@sunag sunag commented Dec 5, 2024 •
edited
Loading

Related issue: #30025

Description

More docs, address TODO.

@sunag sunag marked this pull request as ready for review December 5, 2024 00:55
@sunag sunag added this to the r172 milestone Dec 5, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2024 •
edited
Loading

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 339.11
78.98		 339.11
78.98		 +0 B
+0 B
WebGPU 484.85
134.59		 484.85
134.59		 +0 B
+0 B
WebGPU Nodes 484.31
134.5		 484.31
134.5		 +0 B
+0 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 465
112.04		 465
112.04		 +0 B
+0 B
WebGPU 554.24
150.04		 554.24
150.04		 +0 B
+0 B
WebGPU Nodes 510.12
139.75		 510.12
139.75		 +0 B
+0 B

Mugen87
Mugen87 reviewed Dec 5, 2024
View reviewed changes
src/nodes/core/StackNode.js Outdated Show resolved Hide resolved
@Mugen87 Mugen87 merged commit 3d97470 into mrdoob:dev Dec 5, 2024
10 of 11 checks passed
@sunag sunag deleted the dev-doc-3 branch December 5, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mugen87 Mugen87 Mugen87 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r172
Development

Successfully merging this pull request may close these issues.
2 participants
@sunag @Mugen87