Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VarNode: Fix getMemberType() reference #30427

Merged
merged 1 commit into from
Jan 30, 2025
Merged

VarNode: Fix getMemberType() reference #30427

merged 1 commit into from
Jan 30, 2025

Conversation

sunag
Copy link
Collaborator

@sunag sunag commented Jan 29, 2025

Related issue: #30421

Description

This fixed the loss of member reference if using toVar(), however it should not be recommended for use in structures.

@sunag sunag added this to the r173 milestone Jan 29, 2025
Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 336.27
78.29
336.27
78.29
+0 B
+0 B
WebGPU 516.99
143.53
517.04
143.54
+55 B
+9 B
WebGPU Nodes 516.45
143.42
516.51
143.43
+55 B
+9 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 465.25
112.13
465.25
112.13
+0 B
+0 B
WebGPU 588.99
159.69
589.05
159.7
+55 B
+12 B
WebGPU Nodes 544.38
149.25
544.43
149.26
+55 B
+8 B

@sunag sunag marked this pull request as ready for review January 30, 2025 00:27
@sunag sunag merged commit 558b7c7 into mrdoob:dev Jan 30, 2025
12 checks passed
@sunag sunag deleted the dev-struct3 branch January 30, 2025 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant