Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patch rainydays divide by 0 error in micro_global() #23

Closed
wants to merge 1 commit into from

Conversation

goldingn
Copy link
Contributor

proposed patch to issue #22

I haven't copied this over to micro_global_grid() or micro_terra() where the code is duplicated.

Please also review to make sure it doesn't break the intended use of these functions (I just zeroed out rainfall if no raininy days, but might that mess up totals in some situations?)

Copy link
Owner

@mrke mrke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks Nick - I fixed it a slightly different way by just checking for NA at the end of the construction of RAINFALL and setting any to zero so (and did this for micro_terra too).

@goldingn goldingn closed this Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants