ISSUE-370: Do not cast the path to POSIX style #418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| export function flattenHeavilyConcatenatedString(input: string): string { | ||
| // @ts-expect-error Another solution can be `.trim`, but it changes the string. | ||
| // eslint-disable-next-line @typescript-eslint/no-unused-expressions, no-bitwise, unicorn/prefer-math-trunc | ||
| input | 0; |
Check warning
Code scanning / CodeQL
Expression has no effect
mrmlnc
force-pushed
the
ISSUE-370_absolute_normalize
branch
from
f6262ae to
9917ede
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Addressed to several issues: #370, #379.
The main purpose of these changes is to stop casting the path to POSIX style (even on Windows) when the
absoluteoption is enabled.Current cases:
test-a@(\\\\)/test.js(absoluteoption replaces\in filename to/#379)What changes did you make? (Give an overview)
…