Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable Inline LSP by default #667

Closed
wants to merge 1 commit into from
Closed

Disable Inline LSP by default #667

wants to merge 1 commit into from

Conversation

jergk
Copy link

@jergk jergk commented Oct 12, 2024 •
edited
Loading

Disable LSP by default for now, as this is a breaking change for at least one Language Server.
#666

@ms-jpq
Copy link
Owner

ms-jpq commented Oct 22, 2024 •
edited
Loading

coq_nvim/lua/coq/lsp-request.lua

Line 187 in 2cc819f

local supports_method = function(client, lsp_method, lsp_capability)

a slightly better fix 👍

actually does feature detection for inlineCompletionProvider, tested against HLS ( no longer broken ), tabbyML ( still works ) and copilot ( still works )

@ms-jpq ms-jpq closed this Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jergk @ms-jpq