Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: react-mentions #250

Closed
wants to merge 1 commit into from
Closed

fix: react-mentions #250

wants to merge 1 commit into from

Conversation

cubewhy
Copy link

@cubewhy cubewhy commented Aug 11, 2024

Marged signavio/react-mentions#499

Fix IME (etc. fcitx5)

Copy link

netlify bot commented Aug 11, 2024

Deploy Preview for tailchat-nightly ready!

Name Link
🔨 Latest commit 27e8821
🔍 Latest deploy log https://app.netlify.com/sites/tailchat-nightly/deploys/66b8ab166debb90008b213fc
😎 Deploy Preview https://deploy-preview-250--tailchat-nightly.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@moonrailgun moonrailgun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks too much changes and its looks not a simple patch. where did this changes from?

+ module.exports = require("./react-mentions-fix.cjs.prod.js");
} else {
- module.exports = require("./react-mentions.cjs.dev.js");
+ module.exports = require("./react-mentions-fix.cjs.dev.js");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where is react-mentions-fix

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I copied my own built to the patch. Patch is hardly to edit directly.

@moonrailgun
Copy link
Contributor

suggest to send PR to react-mentions, because i am hard to review so much code changes in a third part library changes.

@cubewhy
Copy link
Author

cubewhy commented Aug 11, 2024

someone always opened a pr to react-metions, but it not responsed so far

@cubewhy cubewhy closed this by deleting the head repository Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants