Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reset slippage on deposit/withdraw token change #295

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

dimlbc
Copy link
Member

@dimlbc dimlbc commented Oct 30, 2023

Issue

Link to Trello card

Description

  • Added trading slippage reset when deposit/withdrawal token changes

Verifying

How to confirm changes, and explain how this was tested

Steps to verify

Expected results

Implementation details

Highlights of how the implementation fixes the issue or anything relevant about a new feature

Screenshots

Before

After

Related PRs

List related PRs against other branches:

Short identifier Source
back-end-related-pr link
some-other_pr link

Todos (if a PR is in work in progress state)

  • Tests
  • Documentation
  • Other things can be put here

@dimlbc dimlbc force-pushed the fix/trading-slippage branch from c741caa to d3432be Compare October 30, 2023 11:23
@github-actions
Copy link

Visit the preview URL for this PR (updated for commit d3432be):

https://frontend-7e17f--pr295-fix-trading-slippage-fxbt87zc.web.app

(expires Tue, 07 Nov 2023 11:30:51 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 5e64a35c9bab805efe8cc6d7f4aabafe8180ef22

@dimlbc dimlbc merged commit 5a1f23a into main Oct 30, 2023
@dimlbc dimlbc deleted the fix/trading-slippage branch October 30, 2023 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants