Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dHEDGE V1 Deprecation): disable redeem transaction when gas price… #311

Merged

Conversation

dimlbc
Copy link
Member

@dimlbc dimlbc commented Sep 30, 2024

… is 0

Issue

Link to Trello card

Description

  1. Check l1baseFee and l2MaxFeePerGas
  2. Disabl Redeem transaction and show popup notification if any is zero
  3. Increase base fee +20%
Screenshot 2024-09-30 at 09 36 19

Verifying

How to confirm changes, and explain how this was tested

Steps to verify

Expected results

Implementation details

Highlights of how the implementation fixes the issue or anything relevant about a new feature

Screenshots

Before

After

Related PRs

List related PRs against other branches:

Short identifier Source
back-end-related-pr link
some-other_pr link

Todos (if a PR is in work in progress state)

  • Tests
  • Documentation
  • Other things can be put here

Copy link

github-actions bot commented Sep 30, 2024

Visit the preview URL for this PR (updated for commit e12bdd9):

https://dhedge-v1-withdraw--pr311-fix-disable-dhedge-v-3hmjktm6.web.app

(expires Wed, 09 Oct 2024 12:20:06 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 2157533cdfb02b956c33a37a482e9873c6f9154b

@dimlbc dimlbc force-pushed the fix/disable-dhedge-v1-redeem-transaction-when-gas-price-is-zero branch from 5a0b166 to e12bdd9 Compare October 1, 2024 12:15
@dimlbc dimlbc merged commit 932ccbe into main Oct 1, 2024
2 checks passed
@dimlbc dimlbc deleted the fix/disable-dhedge-v1-redeem-transaction-when-gas-price-is-zero branch October 1, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant