Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup #6

Merged
merged 31 commits into from
Dec 21, 2024
Merged

Cleanup #6

merged 31 commits into from
Dec 21, 2024

Conversation

SwissalpS
Copy link
Contributor

  • luacheck
  • mod.conf
  • recycling recipes
  • fix formspec invsize -> size and add listring for shift-clicking between inventories
  • replace outdated meta handling
  • replace minetest -> core
  • reduce indentation with smarter 'early exit' code
  • fix pairs() -> ipairs() loop
  • reduce chat spam when trying to dig a machine with items in it: not needed this is a general game mechanic
  • update locales, drop intllib and add Spanish and Catalan
  • restructure crafts to own file
  • general cleanup with more informative comments

@SwissalpS
add luacheck
547e041
@SwissalpS
add mod.conf remove depends.txt
3cabaaf
@SwissalpS
locale: remove unused string
ce95b46
@SwissalpS
move global definition to top
1822570 
along with 'global' functions
@SwissalpS
whitespace and indentation fix part 1
e3957eb 
also minetest.* to core.*
@SwissalpS
move lines part 2
462333c
@SwissalpS
move crafting recipes to own file
d544f89
@SwissalpS
update some comments
400164b 
some comment code comming in subsequent commits
@SwissalpS
cleanup unified_inventory handling
0e7087a 
also add blank sticker to unified_inventory
@SwissalpS
re-order crafts and add missing recycling recipes
61c8f48
@SwissalpS
amendment to unified_inventory cleanup
4a158a7
@SwissalpS
rename vars to avoid shadowing to help understand
4905c94 
also minetest -> core
@SwissalpS
fix blank sticker mess
83977fd
@SwissalpS
whitespace changes
7d598d7
@SwissalpS
use double quotes in user facing strings
2e19eb9
@SwissalpS
remove or comment out not needed lines
a02785e
@SwissalpS
add sticker group for recycling recepes
0082d7b
@SwissalpS
add stray blank sticker registration
3388cdd
@SwissalpS
use moder meta getting method
4f3425c
@SwissalpS
reduce chat spam
7552e1a
@SwissalpS
formspec: remove depricated 'invsize'
17de4c0
@SwissalpS
formspec: add listring
fe03633 
So shift-clicking stacks works
@SwissalpS
use ipairs not pairs for looping list
e847047
@SwissalpS
simplify logic and reduce amount of indents needed
7e0f4c4
@SwissalpS
cleanup: stray stuff
583e280
@SwissalpS
Some more comment tweaks
52703e1
@SwissalpS
Separate block and sticker description
0aef99b
@SwissalpS
locale updates
d8808aa
@SwissalpS
drop intllib and use core translation
f52c3fc
@SwissalpS
locale add Spanish and Catalán
55f7a07
@SwissalpS
update changelog
eb39841 
and tweak some capitalization issues
@SwissalpS SwissalpS added the enhancement New feature or request label Dec 15, 2024
wsor4035
wsor4035 approved these changes Dec 15, 2024
View reviewed changes
Copy link

@wsor4035 wsor4035 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense

@SwissalpS
Copy link
Contributor Author

do we have a problem with the WTF licence in this org? If so we might as well re-licence this.

@BuckarooBanzay
Copy link
Member

do we have a problem with the WTF licence in this org? If so we might as well re-licence this.

don't care IMO 🤷

@S-S-X
Copy link
Member

S-S-X commented Dec 16, 2024

do we have a problem with the WTF licence in this org? If so we might as well re-licence this.

Just CDB had issues with certain licenses like WTFPL and that's why there's been talk about dual licensing on some repos, not sure how it is currently.

@wsor4035 wsor4035 merged commit ac1d13a into master Dec 21, 2024
2 checks passed
@SwissalpS SwissalpS deleted the cleanup branch December 21, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wsor4035 wsor4035 wsor4035 approved these changes

@BuckarooBanzay BuckarooBanzay BuckarooBanzay approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SwissalpS @BuckarooBanzay @S-S-X @wsor4035