Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set string in PlayerMetaRef instead of in player object attribute #92

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Set string in PlayerMetaRef instead of in player object attribute #92

merged 1 commit into from
Jan 9, 2025

Conversation

AntumDeluge
Copy link
Contributor

Replaces calls to player:set_attribute with player:get_meta():set_string.

@BuckarooBanzay BuckarooBanzay added the enhancement New feature or request label Jan 6, 2025
@SwissalpS
Copy link
Contributor

Thanks :D
The getter method already had this updated:

homedecor_modpack/homedecor_wardrobe/init.lua

Line 189 in e5119ca

local skin = player:get_meta():get("homedecor:player_skin")

So we are good to merge.

@SwissalpS SwissalpS merged commit b30d7b5 into mt-mods:master Jan 9, 2025
1 check passed
@AntumDeluge AntumDeluge deleted the player_meta branch January 18, 2025 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BuckarooBanzay BuckarooBanzay BuckarooBanzay approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AntumDeluge @SwissalpS @BuckarooBanzay