substituted youtube-dl with yt-dlp and corrected a bug of youtube streaming

mkchromecast/__init__.py

@@ -157,7 +157,7 @@ def __init__(self, args = None):
             self.codec = args.codec
 
         # TODO(xsdg): Add support for yt-dlp
-        command_choices = ["ffmpeg", "youtube-dl"]
+        command_choices = ["ffmpeg", "yt-dlp"]
         self.command: Optional[str]
         if not args.command:
             self.command = None
@@ -230,13 +230,13 @@ def __init__(self, args = None):
         else:
             if not check_url(args.youtube):
                 youtube_error = """
-                You need to provide a URL that is supported by youtube-dl.
+                You need to provide a URL that is supported by yt-dlp.
                 """
 
                 # TODO(xsdg): Switch to yt-dlp.
                 message = """
                 For a list of supported sources please visit:
-                    https://rg3.github.io/youtube-dl/supportedsites.html
+                    https://github.com/yt-dlp/yt-dlp/blob/master/supportedsites.md?plain=1
 
                 Note that the URLs have to start with https.
                 """

mkchromecast/_arg_parsing.py

@@ -558,12 +558,12 @@ def raise_arg_type_error():
     type=str,
     default=None,
     help="""
-    Stream from sources supported by youtube-dl. This option needs
-    the youtube-dl package, and it also gives you access to all its
+    Stream from sources supported by yt-dlp. This option needs
+    the yt-dlp package, and it also gives you access to all its
     supported websites such as Dailymotion, LiveLeak, and Vimeo.
 
     For a comprehensive list, check:
-        http://rg3.github.io/youtube-dl/supportedsites.html.
+        http://rg3.github.io/yt-dlp/supportedsites.html.
 
     Example:
         python mkchromecast.py -y https://www.youtube.com/watch?v=NVvAJhZVBTc

mkchromecast/audio.py

@@ -37,6 +37,15 @@
 frame_size = 32 * _mkcc.chunk_size
 buffer_size = 2 * _mkcc.chunk_size**2
 
+encode_settings = pipeline_builder.EncodeSettings(
+        codec=_mkcc.codec,
+        adevice=_mkcc.adevice,
+        bitrate=_mkcc.bitrate,
+        frame_size=frame_size,
+        samplerate=str(_mkcc.samplerate),
+        segment_time=_mkcc.segment_time
+    )
+
 debug = _mkcc.debug
 
 if debug is True:
@@ -61,19 +70,11 @@
         query = urllib.parse.parse_qs(url_data.query)
     video = query["v"][0]
     print(colors.options("Playing video:") + " " + video)
-    command = ["youtube-dl", "-o", "-", _mkcc.youtube_url]
+    command = ["yt-dlp", "-o", "-", _mkcc.youtube_url]
     media_type = "audio/mp4"
 else:
     backend.name = _mkcc.backend
-    backend.path = backend.name
-    encode_settings = pipeline_builder.EncodeSettings(
-        codec=_mkcc.codec,
-        adevice=_mkcc.adevice,
-        bitrate=_mkcc.bitrate,
-        frame_size=frame_size,
-        samplerate=str(_mkcc.samplerate),
-        segment_time=_mkcc.segment_time
-    )
+    backend.path = backend.name    
 
     # TODO(xsdg): Why is this only run in tray mode???
     if _mkcc.operation == OpMode.TRAY and backend.name in {"ffmpeg", "parec"}:

mkchromecast/pipeline_builder.py

@@ -239,7 +239,7 @@ def __init__(self, video_settings: VideoSettings):
     @property
     def command(self) -> SubprocessCommand:
         if self._settings.operation == OpMode.YOUTUBE:
-            return ["youtube-dl", "-o", "-", self._settings.youtube_url]
+            return ["yt-dlp", "-o", "-", self._settings.youtube_url]
 
         if self._settings.operation == OpMode.SCREENCAST:
             return self._screencast_command()