Consistently use webkitAudioContext as an alias for AudioContext #194
+5
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is required to support WebAudio on Safari at least till version 10, see http://caniuse.com/#feat=audio-api for use of this prefix.
gagern
added a commit
to gagern/CindyJS
that referenced
this pull request
Sep 15, 2016
This incorporates mudcube/MIDI.js#194 into the MIDI.js library included in our source tree.
montaga
pushed a commit
to montaga/CindyJS
that referenced
this pull request
May 25, 2018
This incorporates mudcube/MIDI.js#194 into the MIDI.js library included in our source tree.
montaga
pushed a commit
to montaga/CindyJS
that referenced
this pull request
May 25, 2018
This incorporates mudcube/MIDI.js#194 into the MIDI.js library included in our source tree.
montaga
pushed a commit
to montaga/CindyJS
that referenced
this pull request
May 30, 2018
This incorporates mudcube/MIDI.js#194 into the MIDI.js library included in our source tree.
montaga
pushed a commit
to montaga/CindyJS
that referenced
this pull request
May 30, 2018
This incorporates mudcube/MIDI.js#194 into the MIDI.js library included in our source tree.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MIDI.js does consider
webkitAudioContextas an alternative toAudioContextin some places, but not consistently so far. The commit at hand changes that. This is required to support WebAudio on Safari at least till version 10, see http://caniuse.com/#feat=audio-api for use of this prefix.