Cache not written to storage after removal of selectors from the last slot #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
April 29, 2020 10:07
On removal of a selector from the last slot, the entire operation happens in the cache (named slot.selectorSlot). There is a flag to mark it 'dirty', called slot.newSlot, which is used correctly when adding new selectors. However it is not changed upon removal, and if you only remove a slot, the cache is not written back. This causes the storage to still contain the removed selector. Final slot before removal: [ sel2 sel3 sel4 sel5 ] Final slot after removal of sel3, cache: [ sel2 sel5 sel4 ] Final slot in storage after removal: [ sel2 sel3 sel4 ] By setting the dirty flag to true, the cache is written back correctly.
|
I didn't see this until now. Thanks a lot for this! I fixed this bug. The testing switched to Truffle so I modified your test to work with Truffle and added your test to the project. Thanks again. |
|
@grebnetiew If you want to contribute more to this project, there's this issue: https://github.com/mudgen/Diamond/issues/7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On removal of a selector from the last slot, the entire operation happens in the cache (named
slot.selectorSlot). There is a flag to mark it 'dirty', calledslot.newSlot, which is used correctly when adding new selectors. However it is not changed upon removal, and if you only remove a slot, the cache is not written back. This causes the storage to still contain the removed selector.Final slot before removal:
Final slot after removal of sel3, cache:
Final slot in storage after removal:
By setting the dirty flag to true, the cache is written back correctly.
The PR adds a test checking if the bug exists.