Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: drop incorrect namespace handling #15

Merged
merged 1 commit into from
Jun 30, 2024

Conversation

muktihari
Copy link
Owner

@muktihari muktihari commented Jun 30, 2024

  • Drop incorrect namespace handling; Handling it correctly requires a lot of bookkeeping.
  • Rename Name.Space to Name.Prefix since we just parsing the prefix not handling the namespace properly.
  • Mark this library as non-namespace parser in README.md.
  • Change IsEndElement() method as IsEndElement (bool) field instead and xml's Name for EndElement will no longer has prefix "/":
    • "/gpx" -> "gpx".

Discussion: https://www.reddit.com/r/golang/comments/1drdji3/xml_tokenizer_thats_4x_faster_than_stdlibs_xml/?utm_source=share&utm_medium=web3x&utm_name=web3xcss&utm_term=1&utm_content=share_button

@muktihari muktihari added the bug Something isn't working label Jun 30, 2024
@muktihari muktihari self-assigned this Jun 30, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (71c4417) to head (46e23b4).

Additional details and impacted files
@@            Coverage Diff            @@
##            master       #15   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines          266       266           
=========================================
  Hits           266       266           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@muktihari muktihari merged commit 1750cca into master Jun 30, 2024
1 check passed
@muktihari muktihari deleted the fix/drop-incorrect-namespace-handling branch June 30, 2024 05:32
@dolmen
Copy link
Contributor

dolmen commented Jun 30, 2024

Please make more granular changes: this PR contains 2 major changes which seems unrelated to me: change of IsEndElement doesn't seem related to namespace handling, at least from an external point of view.

@muktihari
Copy link
Owner Author

Please make more granular changes: this PR contains 2 major changes which seems unrelated to me: change of IsEndElement doesn't seem related to namespace handling, at least from an external point of view.

Will do on next PR since this repo is now gain more traction and I don't want to break someone else code as well. Thanks for pointing this out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants