Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Migrate to C #2

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

[WIP] Migrate to C #2

wants to merge 5 commits into from

Conversation

mukul-mehta
Copy link
Owner

@mukul-mehta mukul-mehta commented Mar 7, 2021 •
edited
Loading

This PR intends to convert the source code to pure C, since we aren't really using any C++ style features

  • Convert getOSName, getUsername and getHostname to use C style char arrays
  • Convert other instances of C++ strings to use C style char arrays
  • Convert vector to dynamic arrays

@mukul-mehta mukul-mehta requested a review from rashil2000 March 7, 2021 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rashil2000 rashil2000 rashil2000 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mukul-mehta @rashil2000