Replace maybenot submodule with direct ffi re-export wrapper crate #22
+312
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes
maybenot
as a submodule. And instead adds a local simple wrapper (re-export?) crate namedmaybenot-ffi
. All this crate does is to depend on the realmaybenot-ffi
crate and re-exports the entire API of it.This change allows us to depend on
maybenot-ffi
from crates.io instead of having it as a git dependency (submodule). This in turn allows us to to trackmaybenot-ffi
and all its dependencies in the parent repository and workspace lockfile, simplifying dependency management and verification.This force us to commit the
maybenot.h
header to this repository. This is explained in the readme. It should no longer be automagically generated. This removes the build time dependency oncbindgen
and helps with reproducible builds also.This change is