net: consider dns addresses as public #219
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sukunrt
force-pushed
the
sukun/public-addr-dns
branch
from
e28b637 to
c0880b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves the discussion here: libp2p/go-libp2p#2553 (review)
For some users this might cause unexpected behaviour e.g. here it looks like the user does want this function to return true only for
IPaddresses. I can imagine there are some others who want this.Most of the cases I eyeballed are not affected by this change and in some cases are positively impacted as they do expect dns addresses to pass this check.
Ideally it'd have been nicer if the existing method was
IsPublicIPAddrand so we could just addIsPublicAddrwith this behaviour.The suffix check is not too expensive. The method takes 90-100ns with IP addresses. It takes 125ns with dns addresses on my m1 macbook.