Add a context menu with a quick option to remove node selections #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waxlamp
reviewed
Feb 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't close an issue, but it's an improvement that we've wanted for a while. I added a context menu with a button to quickly clear the selection. I also used the composition API style and I feel like I'm becoming more familiar with it.
After reviewing the documentation, I saw there was an
@contextmenuevent hook so I'm using that. The only lingering issue was if the user held right click it would draw the rect select, so I made sure that only triggers on a left click by checking which button is pressed in the event handler.This improvement will allow for a couple of improvements requested by Alex, namely #166 and moving some of the menu buttons from the controls to this context menu (like I've done with "Clear Selection")
See #201 for a demo of the functionality