-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move network variables to store #286
Conversation
This code mostly works, there is something going on within the FilterOverlay component where I am calculating the node and edge variables using AQL only if the network was subsetted. The issue seems to be that the state is empty. This is the error I see: I have a feeling that it's due to async loading, but would like to discuss after you take a look |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there are some edge cases that need to be considered, but overall, this works great!
Also, I didn't test this locally. I think we should test an example of 1 node table and 2 or more node tables to make sure that expansion works |
Co-authored-by: Jack Wilburn <[email protected]>
Helps ensure for edge case where node/edge does not have consistent keys
I tested with the Paul Revere dataset. It is pulling from the second table. Also, I am getting a bug with nodes > 1, and edges > 1 in the dropdown. To Do:
|
Was causing issues because you can't map with an empty string
Closes #281
This change will make it possible to switch between queries without refreshing the page.
It will also show all possible options for large networks because it will pull the values from the original network.