-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edge slicing #372
Merged
+870
−2
Merged
Edge slicing #372
Changes from 1 commit
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
a677b64
Add edge slicing component
gotdairyya b580ad6
Add edge slicing component
gotdairyya 7d4a2a6
Use instance for edge slice width
gotdairyya fe0b541
Change cog to chevron
gotdairyya b5aacaa
Refactor edge attribute list creation
gotdairyya d26e069
Represent total edges in edge slices
gotdairyya abe8699
Fix position of tooltip
gotdairyya 485911d
Visualize categorical attributes
gotdairyya 467e52a
Format numeric labels
gotdairyya f6887cb
Remove edge slices on query
gotdairyya 82f685a
Fix most type issues
JackWilb c16d769
Fix tooltip error
gotdairyya 58ef38c
Merge 'origin/main' into edge-slicing
gotdairyya 50ecc03
Show labels under slices for numeric
gotdairyya 6323c14
Add padding
gotdairyya 36e697a
Manage clearing form and sliced network
gotdairyya ea67b17
Reset edge slice number
gotdairyya 01e16c4
Set sliced network to empty on updateNetwork
gotdairyya 83448b8
Fix numeric edge slices
gotdairyya 35ece64
Format edge slicing + fix label display
gotdairyya cd9cf04
Add isTime to reset
gotdairyya 439163e
Disable buttpns when network not sliced
gotdairyya b219da0
Remove unnecessary network update
gotdairyya 95ad01a
Remove unused variables
gotdairyya c303cc5
Remove d3 for edge selection
gotdairyya 4e67144
Check for valid input
gotdairyya 73cae4e
Remove computed ref manipulation
gotdairyya 47e3f9c
Fix categorical slicing
gotdairyya 0fa5f4b
Fix reset clearing removes min and max
gotdairyya 63f104e
Update time selection
gotdairyya File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changing a value on a computed ref like this is dangerous. You should change the computedref to a ref and a watcher on
timeRangesLength
just to reset it when it changes, and then you can modify the array without it magically getting updated by the computed componentThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW (might not apply here) you can use a "computed setter" (V2: https://v2.vuejs.org/v2/guide/computed.html#Computed-Setter) or a "writable computed" (V3: https://vuejs.org/guide/essentials/computed.html#writable-computed) to give semantics to "changing a value on a computed ref".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, this has also been fixed!