Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CPedSA class cleanup & optimization #3656

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

CPedSA class cleanup & optimization #3656

wants to merge 13 commits into from

Conversation

FileEX
Copy link
Contributor

@FileEX FileEX commented Aug 17, 2024 •
edited
Loading

This PR is intended to clean up the CPedSA class.

  • Refactoring of CPedSA.cpp, CPedSA.h, and CPed.h according to the latest coding guidelines and C++ standards
  • Cleanup of the aforementioned files
  • Completion of missing fields in the CPedSAInterface class and cleanup of their types
  • Added classes for interfaces related to ped sounds
  • Minor optimization by reducing unnecessary operations and redundancies.

TracerDS
TracerDS suggested changes Aug 17, 2024
View reviewed changes
Client/game_sa/CPedSA.cpp Outdated Show resolved Hide resolved
Client/game_sa/CPedSA.cpp Outdated Show resolved Hide resolved
Client/game_sa/CPedSA.cpp Outdated Show resolved Hide resolved
Client/game_sa/CPedSA.cpp Show resolved Hide resolved
Client/game_sa/CPedSA.cpp Outdated Show resolved Hide resolved
Client/game_sa/CPedSA.cpp Outdated Show resolved Hide resolved
Client/game_sa/CPedSA.cpp Outdated Show resolved Hide resolved
Client/game_sa/CPedSA.cpp Show resolved Hide resolved
Client/game_sa/CPedSA.h Outdated Show resolved Hide resolved
Client/game_sa/CPedSA.h Outdated Show resolved Hide resolved
Dutchman101
Dutchman101 requested changes Aug 18, 2024
View reviewed changes
Client/sdk/game/CPed.h Outdated Show resolved Hide resolved
TracerDS
TracerDS reviewed Aug 26, 2024
View reviewed changes
Client/game_sa/CPedSA.cpp Outdated Show resolved Hide resolved
Client/game_sa/CPedSA.cpp Outdated Show resolved Hide resolved
Client/game_sa/CPedSA.h Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TracerDS TracerDS TracerDS requested changes

@Dutchman101 Dutchman101 Dutchman101 requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@FileEX @Dutchman101 @TracerDS @tederis