Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wrong function deprecated warnings with variables (Issue #1435) #3927

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Fix wrong function deprecated warnings with variables (Issue #1435) #3927

wants to merge 10 commits into from
+141 −16

Conversation

YelehaUwU
Copy link

@YelehaUwU YelehaUwU commented Jan 5, 2025 •
edited
Loading

This addresses the issue #1435 and fixes the issue by implementing context around the scanned name, ignoring variables.

It is fully tested on a locally hosted server and works fine.

@YelehaUwU YelehaUwU mentioned this pull request Jan 5, 2025
Open
@YelehaUwU YelehaUwU changed the title Fix deprecated function names in variables (PR #1435) Fix deprecated function names in variables (Issue #1435) Jan 5, 2025
Fernando-A-Rocha
Fernando-A-Rocha approved these changes Jan 5, 2025
View reviewed changes
Copy link
Contributor

@Fernando-A-Rocha Fernando-A-Rocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without this PR, banIP = "192.168.1.69" will produce a warning.

I confirm that with these changes, this code no longer produces a warning.

GJ 👍

@YelehaUwU YelehaUwU changed the title Fix deprecated function names in variables (Issue #1435) Fixes wrong deprecated warning with variables (Issue #1435) Jan 5, 2025
@YelehaUwU YelehaUwU changed the title Fixes wrong deprecated warning with variables (Issue #1435) Fix wrong function deprecated warnings with variables (Issue #1435) Jan 5, 2025
@YelehaUwU
Copy link
Author

Screenshot 2025-01-06 071904
Now handles all cases mentioned.

tederis
tederis reviewed Jan 6, 2025
View reviewed changes
Server/mods/deathmatch/logic/CResourceChecker.cpp Outdated Show resolved Hide resolved
Server/mods/deathmatch/logic/CResourceChecker.cpp Outdated Show resolved Hide resolved
Server/mods/deathmatch/logic/CResourceChecker.cpp Outdated Show resolved Hide resolved
Server/mods/deathmatch/logic/CResourceChecker.cpp Outdated Show resolved Hide resolved
@YelehaUwU
Copy link
Author

All changes needed done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tederis tederis tederis left review comments

@TheNormalnij TheNormalnij TheNormalnij left review comments

@Fernando-A-Rocha Fernando-A-Rocha Fernando-A-Rocha approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@YelehaUwU @TheNormalnij @tederis @Fernando-A-Rocha