Fix unintended behavior for ped control states #3964
+38
−96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tederis
reviewed
Jan 18, 2025
tederis
reviewed
Jan 20, 2025
| return SetControlState(szControl, bState); | ||
| } | ||
| if (&ped == GetLocalPlayer()) | ||
| return SetControlState(control.data(), state); |
There was a problem hiding this comment.
Although std::string_view is acceptable in CLuaPedDefs, it's not recommended to use it here because SetPedControlState can potentially be called from any place and a string isn't guaranteed to be null-terminated. The same for GetPedControlState.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3874