refactor sc-storage #219
Merged
refactor sc-storage #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # Cargo.lock # Cargo.toml # bridge-proxy/src/bridge-proxy.rs # bridged-tokens-wrapper/Cargo.toml # bridged-tokens-wrapper/src/lib.rs # common/fee-estimator-module/Cargo.toml # common/sc-proxies/src/esdt_safe_proxy.rs # esdt-safe/Cargo.toml # esdt-safe/src/lib.rs # esdt-safe/tests/esdt_safe_blackbox_test.rs # esdt-safe/wasm/Cargo.lock # esdt-safe/wasm/src/lib.rs # multisig/sc-config.toml
Coverage SummaryTotals
FilesExpand
|
|
Contract comparison - from 697dde1 to c9eb08a
|
common/storage-module/src/lib.rs
Outdated
| &self, | ||
| owner_address: ManagedAddress, | ||
| ) -> SingleValueMapper<ManagedAddress, ManagedAddress> { | ||
| SingleValueMapper::<_, _, ManagedAddress>::new_from_address( |
There was a problem hiding this comment.
get the owner_address there so you dont have to have duplicated code
bridge-proxy/src/config.rs
Outdated
| #[storage_mapper("esdtSafeContractAddress")] | ||
| fn esdt_safe_contract_address(&self) -> SingleValueMapper<ManagedAddress>; | ||
| #[storage_mapper("ownerAddress")] | ||
| fn owner_address_storage(&self) -> SingleValueMapper<ManagedAddress<Self::Api>>; |
CostinCarabas
previously approved these changes
Oct 30, 2024
# Conflicts: # bridged-tokens-wrapper/src/lib.rs # esdt-safe/src/lib.rs # multi-transfer-esdt/tests/multi_transfer_blackbox_test.rs
CostinCarabas
previously approved these changes
Oct 30, 2024
common/sc-proxies/src/lib.rs
Outdated
| @@ -4,5 +4,6 @@ pub mod bridge_proxy_contract_proxy; | |||
| pub mod bridged_tokens_wrapper_proxy; | |||
| pub mod crowdfunding_esdt_proxy; | |||
| pub mod esdt_safe_proxy; | |||
| pub mod mock_multisig_proxy; | |||
There was a problem hiding this comment.
do we need to include mock into productive code ?
dragos-rebegea
approved these changes
Nov 4, 2024
cosmatudor
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.