Skip to content

Merge pull request #158 from multiversx/actions-trigger-on-feat-branches #422

Merge pull request #158 from multiversx/actions-trigger-on-feat-branches

Merge pull request #158 from multiversx/actions-trigger-on-feat-branches #422

GitHub Actions / clippy failed Dec 27, 2023 in 1s

reviewdog [clippy] report

reported by reviewdog 🐶

Findings (1)

multi-transfer-esdt/tests/multi_transfer_blackbox_test.rs|148 col 31| error[E0061]: this method takes 0 arguments but 2 arguments were supplied
--> multi-transfer-esdt/tests/multi_transfer_blackbox_test.rs:148:26
|
148 | .init(bridge_proxy_addr, ManagedAddress::zero()),
| ^^^^ ----------------- ---------------------- unexpected argument of type multiversx_sc::types::ManagedAddress<_>
| |
| unexpected argument of type multiversx_sc::types::ManagedAddress<multiversx_sc_scenario::api::VMHooksApi<multiversx_sc_scenario::api::impl_vh::static_api::StaticApiBackend>>
|
note: method defined here
--> /home/runner/work/mx-bridge-eth-sc-rs/mx-bridge-eth-sc-rs/multi-transfer-esdt/src/lib.rs:18:8
|
18 | fn init(&self) {
| ^^^^
help: remove the extra arguments
|
148 - .init(bridge_proxy_addr, ManagedAddress::zero()),
148 + .init(),
|

Filtered Findings (3)

bridged-tokens-wrapper/tests/dfp_big_uint_test.rs|15 col 22| warning: redundant clone
--> bridged-tokens-wrapper/tests/dfp_big_uint_test.rs:15:22
|
15 | assert!(converted.clone().convert(5).to_raw() == 12345u64);
| ^^^^^^^^ help: remove this
|
note: this value is dropped without further use
--> bridged-tokens-wrapper/tests/dfp_big_uint_test.rs:15:13
|
15 | assert!(converted.clone().convert(5).to_raw() == 12345u64);
| ^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_clone
= note: #[warn(clippy::redundant_clone)] on by default
bridged-tokens-wrapper/tests/dfp_big_uint_test.rs|7 col 5| warning: this let-binding has unit value
--> bridged-tokens-wrapper/tests/dfp_big_uint_test.rs:7:5
|
7 | let _ = DebugApi::dummy();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: omit the let binding: DebugApi::dummy();
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
= note: #[warn(clippy::let_unit_value)] on by default
bridged-tokens-wrapper/tests/dfp_big_uint_test.rs|20 col 5| warning: this let-binding has unit value
--> bridged-tokens-wrapper/tests/dfp_big_uint_test.rs:20:5
|
20 | let _ = DebugApi::dummy();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: omit the let binding: DebugApi::dummy();
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value

Annotations

Check failure on line 148 in multi-transfer-esdt/tests/multi_transfer_blackbox_test.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] multi-transfer-esdt/tests/multi_transfer_blackbox_test.rs#L148

error[E0061]: this method takes 0 arguments but 2 arguments were supplied
   --> multi-transfer-esdt/tests/multi_transfer_blackbox_test.rs:148:26
    |
148 |                         .init(bridge_proxy_addr, ManagedAddress::zero()),
    |                          ^^^^ -----------------  ---------------------- unexpected argument of type `multiversx_sc::types::ManagedAddress<_>`
    |                               |
    |                               unexpected argument of type `multiversx_sc::types::ManagedAddress<multiversx_sc_scenario::api::VMHooksApi<multiversx_sc_scenario::api::impl_vh::static_api::StaticApiBackend>>`
    |
note: method defined here
   --> /home/runner/work/mx-bridge-eth-sc-rs/mx-bridge-eth-sc-rs/multi-transfer-esdt/src/lib.rs:18:8
    |
18  |     fn init(&self) {
    |        ^^^^
help: remove the extra arguments
    |
148 -                         .init(bridge_proxy_addr, ManagedAddress::zero()),
148 +                         .init(),
    |
Raw output
multi-transfer-esdt/tests/multi_transfer_blackbox_test.rs:148:31:e:error[E0061]: this method takes 0 arguments but 2 arguments were supplied
   --> multi-transfer-esdt/tests/multi_transfer_blackbox_test.rs:148:26
    |
148 |                         .init(bridge_proxy_addr, ManagedAddress::zero()),
    |                          ^^^^ -----------------  ---------------------- unexpected argument of type `multiversx_sc::types::ManagedAddress<_>`
    |                               |
    |                               unexpected argument of type `multiversx_sc::types::ManagedAddress<multiversx_sc_scenario::api::VMHooksApi<multiversx_sc_scenario::api::impl_vh::static_api::StaticApiBackend>>`
    |
note: method defined here
   --> /home/runner/work/mx-bridge-eth-sc-rs/mx-bridge-eth-sc-rs/multi-transfer-esdt/src/lib.rs:18:8
    |
18  |     fn init(&self) {
    |        ^^^^
help: remove the extra arguments
    |
148 -                         .init(bridge_proxy_addr, ManagedAddress::zero()),
148 +                         .init(),
    |


__END__