Skip to content

custom encode/decode #28

custom encode/decode

custom encode/decode #28

GitHub Actions / clippy failed Feb 28, 2024 in 1s

reviewdog [clippy] report

reported by reviewdog 🐶

Findings (4)

multi-transfer-esdt/src/lib.rs|64 col 63| warning: this expression creates a reference which is immediately dereferenced by the compiler
--> multi-transfer-esdt/src/lib.rs:64:63
|
64 | if self.must_refund_tx_with_call_data(&call_data) {
| ^^^^^^^^^^ help: change this to: call_data
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: #[warn(clippy::needless_borrow)] on by default
multi-transfer-esdt/src/lib.rs|64 col 63| warning: this expression creates a reference which is immediately dereferenced by the compiler
--> multi-transfer-esdt/src/lib.rs:64:63
|
64 | if self.must_refund_tx_with_call_data(&call_data) {
| ^^^^^^^^^^ help: change this to: call_data
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: #[warn(clippy::needless_borrow)] on by default
multisig/tests/multisig_setup/mod.rs|115 col 18| warning: the loop variable i is only used to index oracles
--> multisig/tests/multisig_setup/mod.rs:115:18
|
115 | for i in 0..2 {
| ^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
= note: #[warn(clippy::needless_range_loop)] on by default
help: consider using an iterator
|
115 | for in oracles.iter().take(2) {
| ~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~
multisig/tests/multisig_setup/mod.rs|123 col 18| warning: the loop variable i is only used to index oracles
--> multisig/tests/multisig_setup/mod.rs:123:18
|
123 | for i in 0..2 {
| ^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
help: consider using an iterator
|
123 | for in oracles.iter().take(2) {
| ~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~

Filtered Findings (0)

Annotations

Check warning on line 64 in multi-transfer-esdt/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] multi-transfer-esdt/src/lib.rs#L64

warning: this expression creates a reference which is immediately dereferenced by the compiler
  --> multi-transfer-esdt/src/lib.rs:64:63
   |
64 |                         if self.must_refund_tx_with_call_data(&call_data) {
   |                                                               ^^^^^^^^^^ help: change this to: `call_data`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
   = note: `#[warn(clippy::needless_borrow)]` on by default
Raw output
multi-transfer-esdt/src/lib.rs:64:63:w:warning: this expression creates a reference which is immediately dereferenced by the compiler
  --> multi-transfer-esdt/src/lib.rs:64:63
   |
64 |                         if self.must_refund_tx_with_call_data(&call_data) {
   |                                                               ^^^^^^^^^^ help: change this to: `call_data`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
   = note: `#[warn(clippy::needless_borrow)]` on by default


__END__

Check warning on line 64 in multi-transfer-esdt/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] multi-transfer-esdt/src/lib.rs#L64

warning: this expression creates a reference which is immediately dereferenced by the compiler
  --> multi-transfer-esdt/src/lib.rs:64:63
   |
64 |                         if self.must_refund_tx_with_call_data(&call_data) {
   |                                                               ^^^^^^^^^^ help: change this to: `call_data`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
   = note: `#[warn(clippy::needless_borrow)]` on by default
Raw output
multi-transfer-esdt/src/lib.rs:64:63:w:warning: this expression creates a reference which is immediately dereferenced by the compiler
  --> multi-transfer-esdt/src/lib.rs:64:63
   |
64 |                         if self.must_refund_tx_with_call_data(&call_data) {
   |                                                               ^^^^^^^^^^ help: change this to: `call_data`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
   = note: `#[warn(clippy::needless_borrow)]` on by default


__END__

Check warning on line 115 in multisig/tests/multisig_setup/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] multisig/tests/multisig_setup/mod.rs#L115

warning: the loop variable `i` is only used to index `oracles`
   --> multisig/tests/multisig_setup/mod.rs:115:18
    |
115 |         for i in 0..2 {
    |                  ^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
    = note: `#[warn(clippy::needless_range_loop)]` on by default
help: consider using an iterator
    |
115 |         for <item> in oracles.iter().take(2) {
    |             ~~~~~~    ~~~~~~~~~~~~~~~~~~~~~~
Raw output
multisig/tests/multisig_setup/mod.rs:115:18:w:warning: the loop variable `i` is only used to index `oracles`
   --> multisig/tests/multisig_setup/mod.rs:115:18
    |
115 |         for i in 0..2 {
    |                  ^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
    = note: `#[warn(clippy::needless_range_loop)]` on by default
help: consider using an iterator
    |
115 |         for <item> in oracles.iter().take(2) {
    |             ~~~~~~    ~~~~~~~~~~~~~~~~~~~~~~


__END__

Check warning on line 123 in multisig/tests/multisig_setup/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] multisig/tests/multisig_setup/mod.rs#L123

warning: the loop variable `i` is only used to index `oracles`
   --> multisig/tests/multisig_setup/mod.rs:123:18
    |
123 |         for i in 0..2 {
    |                  ^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
help: consider using an iterator
    |
123 |         for <item> in oracles.iter().take(2) {
    |             ~~~~~~    ~~~~~~~~~~~~~~~~~~~~~~
Raw output
multisig/tests/multisig_setup/mod.rs:123:18:w:warning: the loop variable `i` is only used to index `oracles`
   --> multisig/tests/multisig_setup/mod.rs:123:18
    |
123 |         for i in 0..2 {
    |                  ^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
help: consider using an iterator
    |
123 |         for <item> in oracles.iter().take(2) {
    |             ~~~~~~    ~~~~~~~~~~~~~~~~~~~~~~


__END__