Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sovereign] Multiple incoming events processor #6690

Conversation

mariusmihaic
Copy link
Contributor

@mariusmihaic mariusmihaic commented Dec 20, 2024

Reasoning behind the pull request

  • Refactor incoming events processor to act as a holder of multiple incoming event processors

Proposed changes

  • Moved the switch code from incomingEventsProcessor.go into depositEventProc.go & executedBridgeOpEvent.go
  • Now the sovereign sdk users can define their own subscribed incoming events (NotifierConfig.SubscribedEvents from sovereignConfig.toml) and implement the corresponding processor, which will be added by calling RegisterEventHandler
    from incomingHeaderProcessor

Testing procedure

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

@mariusmihaic mariusmihaic self-assigned this Dec 20, 2024
@mariusmihaic mariusmihaic marked this pull request as ready for review January 8, 2025 13:09
axenteoctavian
axenteoctavian previously approved these changes Jan 9, 2025
sasurobert
sasurobert previously approved these changes Feb 6, 2025
Base automatically changed from MX-16369-propose-block-with-last-cross-chain-hash to feat/chain-go-sdk February 6, 2025 14:39
@mariusmihaic mariusmihaic dismissed stale reviews from sasurobert and axenteoctavian February 6, 2025 14:39

The base branch was changed.

@mariusmihaic mariusmihaic merged commit 7248ffd into feat/chain-go-sdk Feb 7, 2025
6 checks passed
@mariusmihaic mariusmihaic deleted the MX-15290-incomingEventsProcessor-with-multiple-proccessors branch February 7, 2025 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants