Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GRPC and NotifierConfig update #6744

Open
wants to merge 3 commits into
base: MX-16271-indexing-incoming-tokens
Choose a base branch
from
Open

GRPC and NotifierConfig update #6744

wants to merge 3 commits into from

Conversation

axenteoctavian
Copy link
Contributor

@axenteoctavian axenteoctavian commented Jan 28, 2025 •
edited
Loading

Reasoning behind the pull request

  • GRPC server disabled by default
  • NotifierConfig disabled by default

Proposed changes

  • make GRPC server disabled by default
  • make NotifierConfig disabled by default
  • Enable both services with sovereign deploy scripts

Testing procedure

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

@axenteoctavian axenteoctavian self-assigned this Jan 28, 2025
@axenteoctavian axenteoctavian marked this pull request as ready for review January 28, 2025 14:50
@axenteoctavian axenteoctavian changed the title start with disabled grpc server, enable with sovereign deploy scripts GRPC server and NotifierConfig update Jan 28, 2025
@axenteoctavian axenteoctavian changed the title GRPC server and NotifierConfig update GRPC and NotifierConfig update Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@axenteoctavian axenteoctavian

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@axenteoctavian