Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass non-root user, pass observer display name, apply renaming #23

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Pass non-root user, pass observer display name, apply renaming #23

wants to merge 4 commits into from

Conversation

andreibancioiu
Copy link
Contributor

@andreibancioiu andreibancioiu commented Nov 17, 2022 •
edited
Loading

  • Pass DOCKER_USER from *.env, as user: ${DOCKER_USER} in the docker-compose files (useful to run the containers with non-root users)
  • Pass OBSERVER_DISPLAY_NAME from *.env as --display-name=${OBSERVER_DISPLAY_NAME}. The name will be displayed on Explorer.
  • Apply further renaming (Docker services & network): Elrond to MultiversX.

@andreibancioiu andreibancioiu self-assigned this Nov 17, 2022
@andreibancioiu andreibancioiu marked this pull request as ready for review November 17, 2022 20:38
@iulianpascalau iulianpascalau self-requested a review November 18, 2022 09:16
@andreibancioiu andreibancioiu marked this pull request as draft November 18, 2022 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iulianpascalau iulianpascalau iulianpascalau approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees

@andreibancioiu andreibancioiu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andreibancioiu @iulianpascalau