Claim developer rewards: remove exceptions (isContractResultOfOpaquel…

…yClaimingDeveloperRewards).
multiversx · Aug 9, 2024 · 1c0813b · 1c0813b
1 parent b648dec
commit 1c0813b
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 38 deletions.
diff --git a/server/services/exceptions.go b/server/services/exceptions.go
diff --git a/server/services/transactionsTransformer.go b/server/services/transactionsTransformer.go
@@ -152,19 +152,6 @@ func (transformer *transactionsTransformer) unsignedTxToRosettaTx(
 				},
 			}
 		}
-
-		if isContractResultOfOpaquelyClaimingDeveloperRewards(scr) {
-			return &types.Transaction{
-				TransactionIdentifier: hashToTransactionIdentifier(scr.Hash),
-				Operations: []*types.Operation{
-					{
-						Type:    opScResult,
-						Account: addressToAccountIdentifier(scr.Receiver),
-						Amount:  transformer.extension.valueToNativeAmount(scr.Value),
-					},
-				},
-			}
-		}
 	}
 
 	return &types.Transaction{

diff --git a/systemtests/check_with_mesh_cli.py b/systemtests/check_with_mesh_cli.py
@@ -61,7 +61,7 @@ def run_rosetta(configuration: Configuration):
     command = [
         str(constants.PATH_ROSETTA),
         f"--port={constants.PORT_ROSETTA}",
-        f"--observer-http-url=http://localhost:{constants.PORT_OBSERVER_SURROGATE}",
+        f"--observer-http-url={constants.URL_OBSERVER_SURROGATE}",
         f"--observer-actual-shard={configuration.network_shard}",
         f"--network-id={configuration.network_id}",
         f"--network-name={configuration.network_name}",

diff --git a/systemtests/config.py b/systemtests/config.py
@@ -11,6 +11,7 @@ class Configuration:
     native_currency: str
     config_file_custom_currencies: str
     num_historical_epochs: int
+    observer_url: str
     proxy_url: str
     check_construction_native_configuration_file: str
     check_construction_custom_configuration_file: str
@@ -31,6 +32,7 @@ class Configuration:
         native_currency="EGLD",
         config_file_custom_currencies="systemtests/rosetta_config/devnet-custom-currencies.json",
         num_historical_epochs=2,
+        observer_url="",
         proxy_url="https://devnet-gateway.multiversx.com",
         check_construction_native_configuration_file="systemtests/mesh_cli_config/devnet-construction-native.json",
         check_construction_custom_configuration_file="systemtests/mesh_cli_config/devnet-construction-custom.json",
@@ -46,7 +48,8 @@ class Configuration:
         network_name="untitled",
         native_currency="EGLD",
         config_file_custom_currencies="systemtests/rosetta_config/testnet-custom-currencies.json",
-        num_historical_epochs=2,
+        num_historical_epochs=1,
+        observer_url="",
         proxy_url="https://testnet-gateway.multiversx.com",
         check_construction_native_configuration_file="systemtests/mesh_cli_config/testnet-construction-native.json",
         check_construction_custom_configuration_file="systemtests/mesh_cli_config/testnet-construction-custom.json",

diff --git a/systemtests/constants.py b/systemtests/constants.py
@@ -4,5 +4,5 @@
 PATH_ROSETTA = PATH_REPOSITORY / "cmd" / "rosetta" / "rosetta"
 PATH_PROXY_TO_OBSERVER_ADAPTER = PATH_REPOSITORY / "systemtests" / "proxyToObserverAdapter"
 PORT_ROSETTA = 7091
-PORT_OBSERVER_SURROGATE = 8080
+URL_OBSERVER_SURROGATE = "http://localhost:8080"
 ADAPTER_DELAY_IN_MILLISECONDS = 100