Send bitmap + epoch in outgoing operations #15
Conversation
mariusmihaic
changed the base branch from
main
to
feat/sovereign-cross-validators-changes
| @@ -5,7 +5,9 @@ import ( | |||
| "testing" | |||
|
|
|||
| "github.com/multiversx/mx-chain-core-go/data/sovereign" | |||
|
|
|||
|
|
||
| return append(registerBridgeOpData, hashesHexEncodedArgs...) | ||
| bridgeDataArgs := []byte( | ||
| "@" + hex.EncodeToString(bridgeData.PubKeysBitmap) + |
There was a problem hiding this comment.
I would put PubKeysBitmap before or after AggregatedSignature, not at the end
| return append(registerBridgeOpData, hashesHexEncodedArgs...) | ||
| bridgeDataArgs := []byte( | ||
| "@" + hex.EncodeToString(bridgeData.PubKeysBitmap) + | ||
| "@" + hex.EncodeToString(uint32ToBytes(bridgeData.Epoch))) |
There was a problem hiding this comment.
Do we really need the Epoch?
Do we really need a to keep all the maps <epoch, validators> in the contract storage?
There was a problem hiding this comment.
I see now why we need to keep the history. Maybe there are unconfirmed operations sent in the epoch 1, but were signed by the validators in epoch 0
There was a problem hiding this comment.
it is better to keep for at least 2-3 epochs.
| return append(registerBridgeOpData, hashesHexEncodedArgs...) | ||
| bridgeDataArgs := []byte( | ||
| "@" + hex.EncodeToString(bridgeData.PubKeysBitmap) + | ||
| "@" + hex.EncodeToString(uint32ToBytes(bridgeData.Epoch))) |
There was a problem hiding this comment.
it is better to keep for at least 2-3 epochs.
|
|
||
| return append(registerBridgeOpData, hashesHexEncodedArgs...) | ||
| bridgeDataArgs := []byte( | ||
| "@" + hex.EncodeToString(bridgeData.PubKeysBitmap) + |
There was a problem hiding this comment.
It's mandatory to have bitmap + epoch before hashesHexEncodedArgs so the contract can decode the arguments properly.
Append validators pub keys bitmap + epoch at the end of the register operation for cross chain txs from sov->main.
Epoch uint32 will be big endian converted to []byte