[SERVICES-2155] context tracker #1296
Conversation
Signed-off-by: Claudiu Lataretu <[email protected]>
Signed-off-by: Claudiu Lataretu <[email protected]>
Signed-off-by: Claudiu Lataretu <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## development #1296 +/- ##
===============================================
- Coverage 56.43% 56.38% -0.06%
===============================================
Files 236 236
Lines 7926 7946 +20
Branches 527 532 +5
===============================================
+ Hits 4473 4480 +7
- Misses 3004 3013 +9
- Partials 449 453 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| context && | ||
| context.deepHistoryTimestamp | ||
| ) { | ||
| resourceUrl = `${resourceUrl}×tamp=${context.deepHistoryTimestamp}`; |
There was a problem hiding this comment.
I think the & could cause issues when no other query arguments are present. It should be a ? in that case
There was a problem hiding this comment.
right. maybe we can use this: https://developer.mozilla.org/en-US/docs/Web/API/URLSearchParams/append
- fix typo - fix resource url generator in mx.api.service.ts Signed-off-by: Claudiu Lataretu <[email protected]>
Signed-off-by: Claudiu Lataretu <[email protected]>
Reasoning
Proposed Changes
How to test
timestampin request headers should return data from the past