Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SERVICES-2532] Expose extra fields on pair model #1416

Conversation

mad2sm0key
Copy link
Contributor

@mad2sm0key mad2sm0key commented Aug 7, 2024

Reasoning

  • exposing the farm address and staking proxy address on the Pair model would reduce the number of needed queries on the Create position page

Proposed Changes

  • expose farmAddress and stakingProxyAddress fields on the Pair model

How to test

query {
  filteredPairs(
    filters: {}
    pagination: { first: 100 }
    sorting: { sortField: TVL, sortOrder: DESC }
  ) {
    edges {
      cursor
      node {
        address
        firstToken {
          name
          identifier
        }
        secondToken {
          name
          identifier
        }
        farmAddress
        stakingProxyAddress
      }
    }
    pageInfo {
      startCursor
      endCursor
    }
    pageData {
      count
      limit
      offset
    }
  }
}

@mad2sm0key mad2sm0key marked this pull request as ready for review August 7, 2024 09:48
@cfaur09
Copy link

cfaur09 commented Aug 7, 2024

tested 🟢

@claudiulataretu claudiulataretu merged commit b5b426f into feat/xexchange-v3 Aug 7, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants