Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SERVICES-2621] Update transaction generation for Farms SC #1496

Merged
merged 2 commits into from
Oct 7, 2024
Merged

[SERVICES-2621] Update transaction generation for Farms SC #1496

merged 2 commits into from
Oct 7, 2024

Conversation

mad2sm0key
Copy link
Contributor

Reasoning

  • use SmartContractTransactionsFactory for generating transactions for Farms SC

Proposed Changes

  • update all farm transaction services (base, v1.2, v1.3, v2) methods
  • add sender parameter where needed + update resolver methods
  • fix unit tests

How to test

  • N/A

@bogdan-rosianu bogdan-rosianu self-requested a review October 7, 2024 13:17
@mad2sm0key mad2sm0key merged commit 183a63c into feat/sdk-core-v13 Oct 7, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bogdan-rosianu bogdan-rosianu bogdan-rosianu approved these changes

@claudiulataretu claudiulataretu claudiulataretu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mad2sm0key @claudiulataretu @bogdan-rosianu