[ MEX-666 ] Currency Converter #1551
Open
+174
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EmanuelMiron
changed the title
mad2sm0key
reviewed
Jan 31, 2025
| @@ -323,6 +323,14 @@ export class ApiConfigService { | |||
| return elasticSearchUrl; | |||
| } | |||
|
|
|||
| getOepnExchangeRateAppID(): string { | |||
There was a problem hiding this comment.
Small typo : getOepnExchangeRateAppID -> getOpenExchangeRateAppID
| @@ -323,6 +323,14 @@ export class ApiConfigService { | |||
| return elasticSearchUrl; | |||
| } | |||
|
|
|||
| getOepnExchangeRateAppID(): string { | |||
| const app_id = this.configService.get<string>('OPEN_EXCHANGE_RATES_APP_ID'); | |||
| if (!app_id) { | |||
There was a problem hiding this comment.
We use camelCase when declaring variables -> appId
|
|
||
| try { | ||
| const response = await this.apiService.get( | ||
| 'https://openexchangerates.org/api/latest.json', |
There was a problem hiding this comment.
Maybe move the URL in the .env file as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasoning
Proposed Changes
How to test