Launchpad v2 audit fixes #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dorin-iancu
reviewed
Nov 13, 2024
Comment on lines
+199
to
+205
| fn check_caller_owner_or_user(&self) { | ||
| if self.blockchain().get_owner_address() == self.blockchain().get_caller() { | ||
| return; | ||
| } | ||
|
|
||
| self.blockchain().check_caller_is_user_account(); | ||
| } |
There was a problem hiding this comment.
This doesn't respect the doc, i.e. or an account from another shard, you just check the caller is a user account.
There was a problem hiding this comment.
Indeed, this was not what was requested, but it is a more simpler and clear/cleaner solution. which covers the initial request. No need for external SCs to call this function.
Coverage SummaryTotals
FilesExpand
|
psorinionut
changed the base branch from
setup-config-optimization-tryout
to
main
framework upgrade 0.54.1
…arameters launchpad v2 addTickets new parameter types
…tests Audit fixes unit tests
dorin-iancu
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.