Round based Launchpad #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage SummaryTotals
FilesExpand
|
dorin-iancu
reviewed
Jan 22, 2025
Comment on lines
+98
to
+103
| #[endpoint(refundUserTickets)] | ||
| fn refund_user_tickets(&self, users_list: MultiValueEncoded<ManagedAddress>) { | ||
| let users_vec = users_list.to_vec(); | ||
| self.add_users_to_blacklist(&users_vec); | ||
| self.clear_users_with_guaranteed_ticket_after_blacklist(&users_vec); | ||
| } |
There was a problem hiding this comment.
Either simply call add_users_to_blacklist_endpoint, or, if the event is that important, make a common function blacklist_users where you do the common logic and just fire the event in add_users_to_blacklist_endpoint
There was a problem hiding this comment.
We need the function to be without an event, like the blacklist method. I understand that it could be easier and more logical from the coding point of view to make a common function, but in this case, I think it is ok to actually have these lines separately, without what is out of scope.
| @@ -5,11 +5,11 @@ use launchpad_common::{config, launch_stage}; | |||
|
|
|||
| pub const MAX_PERCENTAGE: u64 = 10_000; | |||
| pub const MAX_UNLOCK_MILESTONES_ENTRIES: usize = 60; | |||
| pub const MAX_RELEASE_EPOCH_DIFF: u64 = 1800; | |||
| pub const MAX_RELEASE_DIFF: u64 = 60 * 60 * 24 * 365 * 5; | |||
There was a problem hiding this comment.
As a code reader, I have to think that this means... 5 years? Add a comment.
There was a problem hiding this comment.
Not really. It was 5 years when we used timestamps. Now, If we get to a 0.6s round duration, it will be less that 5 years. But at the same time, I don't want to specify the constant's value based on what we assume will be the block duration. Maybe make the multiply and put the value directly?
There was a problem hiding this comment.
Added a new, fixed value.
CostinCarabas
approved these changes
Jan 22, 2025
This was referenced Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates all the Launchpad SCs to use rounds across the board. From setup to vesting.
Includes the refund user tickets functionality.