Tool 373 mark as deprecated all legacy functions #567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
popenta
reviewed
Jan 29, 2025
src/abi/interaction.ts
Outdated
| @@ -21,7 +21,7 @@ interface ISmartContractWithinInteraction { | |||
| } | |||
|
|
|||
| /** | |||
| * Legacy component. Use "SmartContractTransactionsFactory" (for transactions) or "SmartContractQueriesController" (for queries), instead. | |||
| * @deprecated component. Use "SmartContractTransactionsFactory" (for transactions) or "SmartContractQueriesController" (for queries), instead. | |||
There was a problem hiding this comment.
this does not exist anymore: SmartContractQueriesController. Change to:
Use "SmartContractTransactionsFactory" or "SmartContractController", instead.
or something similar.
andreibancioiu
previously approved these changes
Jan 29, 2025
| transaction.setSender(alice.address); | ||
| transaction.applySignature(await alice.signer.sign(transaction.serializeForSigning())); | ||
| transaction.sender = alice.address; | ||
| transaction.signature = await alice.signer.sign(transactionComputer.computeBytesForSigning(transaction)); |
There was a problem hiding this comment.
In a future PR, since now we have the Account class, maybe replace alice.signer.sign(...) withalice.signTransaction(...)?
| assert.equal(deployTransaction.gasLimit, 1000000n); | ||
| assert.equal(deployTransaction.nonce, 42n); | ||
|
|
||
| // Sign the transaction | ||
| deployTransaction.applySignature(await alice.signer.sign(deployTransaction.serializeForSigning())); | ||
| deployTransaction.signature = await alice.signer.sign(computer.computeBytesForSigning(deployTransaction)); |
There was a problem hiding this comment.
Same comment / signTransaction etc.
| @@ -13,7 +13,7 @@ import { TransferTransactionsFactory } from "./transfers/transferTransactionsFac | |||
|
|
|||
| describe("test transaction", function () { | |||
| let alice: TestWallet, bob: TestWallet; | |||
|
|
|||
| const transactionComputer = new TransactionComputer(); | |||
There was a problem hiding this comment.
Missing empty line below (here, and in a few other files that have been changed).
src/transaction.local.net.spec.ts
Outdated
Comment on lines
59
to
61
| transactionOne.nonce = alice.account.nonce; | ||
| alice.account.incrementNonce(); | ||
| transactionTwo.setNonce(alice.account.nonce); | ||
| transactionTwo.nonce = alice.account.nonce; |
There was a problem hiding this comment.
Maybe we can even use getThenIncrementNonce() - this is the place it excels?
popenta
reviewed
Jan 29, 2025
src/abi/interaction.ts
Outdated
| @@ -21,7 +21,7 @@ interface ISmartContractWithinInteraction { | |||
| } | |||
|
|
|||
| /** | |||
| * @deprecated component. Use "SmartContractTransactionsFactory" (for transactions) or "SmartContractQueriesController" (for queries), instead. | |||
| * @deprecated component. Use "SmartContractTransactionsFactory" (for transactions) or "SmartContractController" (for queries), instead. | |||
There was a problem hiding this comment.
the controller can be used for transactions, as well.
| @@ -11,7 +11,7 @@ import { ProxyNetworkProvider } from "./proxyNetworkProvider"; | |||
|
|
|||
| describe("ProxyNetworkProvider Tests", function () { | |||
| const proxy = new ProxyNetworkProvider("https://devnet-gateway.multiversx.com"); | |||
|
|
|||
| const transactionComputer = new TransactionComputer(); | |||
| it("should fetch network configuration", async () => { | |||
andreibancioiu
approved these changes
Jan 29, 2025
popenta
approved these changes
Jan 29, 2025
danielailie
deleted the
TOOL-373-mark-as-deprecated-all-legacy-functions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.