Update tests to use account.signTransaction #571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| const userVerifier = new UserVerifier(new UserPublicKey(wallets.alice.address.getPublicKey())); | ||
| const userVerifier = new UserVerifier(alice.publicKey); |
There was a problem hiding this comment.
Can use account.verify()?
Now I see, that we don't have separate verify_transaction and verify_message:
How about having so?
There was a problem hiding this comment.
I will add this but in the next pr if that's ok. I don't want to add functionality on this pr as is enough big as it is
| @@ -373,7 +365,7 @@ describe("ApiNetworkProvider Tests", function () { | |||
| data: new Uint8Array(Buffer.from("dummy@05")), | |||
| }); | |||
| transaction.nonce = nonce + 1n; | |||
| transaction.signature = await bob.signer.sign(transactionComputer.computeBytesForSigning(transaction)); | |||
| transaction.signature = bob.signTransaction(transaction); | |||
| @@ -298,7 +289,7 @@ describe("ProxyNetworkProvider Tests", function () { | |||
| let txOnNetwork = await proxy.simulateTransaction(transaction); | |||
| assert.deepEqual(txOnNetwork.status, new TransactionStatus("success")); | |||
|
|
|||
| transaction.signature = await bob.signer.sign(transactionComputer.computeBytesForSigning(transaction)); | |||
| transaction.signature = bob.signTransaction(transaction); | |||
There was a problem hiding this comment.
await - here and in other places, as needed?
popenta
reviewed
Jan 31, 2025
Comment on lines
271
to
275
| deployTransaction.nonce = alice.getNonceThenIncrement(); | ||
|
|
||
| deployTransaction.signature = await alice.signer.sign( | ||
| Buffer.from(transactionComputer.computeBytesForSigning(deployTransaction)), | ||
| ); | ||
| deployTransaction.signature = alice.signTransaction(deployTransaction); | ||
|
|
||
| const contractAddress = SmartContract.computeAddress(alice.address, alice.account.nonce); | ||
| alice.account.incrementNonce(); | ||
| const contractAddress = SmartContract.computeAddress(alice.address, alice.nonce); |
There was a problem hiding this comment.
if you use getNonceThenIncrement() and then try to compute the contract's address using alice.nonce you'll have a higher nonce than the one on the transaction, thus computing an invalid address.
Comment on lines
359
to
363
| deployTransaction.nonce = alice.getNonceThenIncrement(); | ||
|
|
||
| deployTransaction.signature = await alice.signer.sign( | ||
| Buffer.from(transactionComputer.computeBytesForSigning(deployTransaction)), | ||
| ); | ||
| deployTransaction.signature = alice.signTransaction(deployTransaction); | ||
|
|
||
| const contractAddress = SmartContract.computeAddress(alice.address, alice.account.nonce); | ||
| alice.account.incrementNonce(); | ||
| const contractAddress = SmartContract.computeAddress(alice.address, alice.nonce); |
|
|
||
| const contractAddress = SmartContract.computeAddress(alice.address, alice.account.nonce); | ||
| alice.account.incrementNonce(); | ||
| const contractAddress = SmartContract.computeAddress(alice.address, alice.nonce); |
There was a problem hiding this comment.
same comment with the higher nonce and wrong contract address.
|
|
||
| const contractAddress = SmartContract.computeAddress(alice.address, alice.account.nonce); | ||
| alice.account.incrementNonce(); | ||
| const contractAddress = SmartContract.computeAddress(alice.address, alice.nonce); |
|
|
||
| const contractAddress = SmartContract.computeAddress(alice.address, alice.account.nonce); | ||
| alice.account.incrementNonce(); | ||
| const contractAddress = SmartContract.computeAddress(alice.address, alice.nonce); |
|
|
||
| const contractAddress = SmartContract.computeAddress(alice.address, alice.account.nonce); | ||
| alice.account.incrementNonce(); | ||
| const contractAddress = SmartContract.computeAddress(alice.address, alice.nonce); |
andreibancioiu
approved these changes
Feb 3, 2025
popenta
approved these changes
Feb 3, 2025
danielailie
deleted the
TOOL-451-use-account-sign-transaction-in-tests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.