New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve errors handling #22

Open

juliancwirko wants to merge 1 commit into multiversx:main from juliancwirko:improve-errors-handling

Contributor

juliancwirko commented May 5, 2024

There could be a better way to improve that. Maybe on the message event listeners' side, but this change makes the errors more readable.

Change the main message to 'Transaction failed' instead of 'Transaction canceled,' which is more general
Spread the try catch also for startBgrMsgChannel Promise
Catch the extensionResponse when it is not an array of transactions. When someone cancels the process.

Instead:

Transaction canceled: extensionResponse.map is not a function.

We now have:

Transaction failed: CanceledError.


          improve errors handling

d6b0547

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet