Merge pull request #184 from EtienneWallet/fix-wrong-bigint-prototype

Fix wrong bigint prototype
multiversx · Jan 20, 2025 · 43cae7b · 43cae7b
2 parents d8c53dc + b9ad4c0
commit 43cae7b
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 2 deletions.
diff --git a/multiversx_sdk/abi/abi.py b/multiversx_sdk/abi/abi.py
@@ -14,6 +14,7 @@
 )
 from multiversx_sdk.abi.address_value import AddressValue
 from multiversx_sdk.abi.array_value import ArrayValue
+from multiversx_sdk.abi.bigint_value import BigIntValue
 from multiversx_sdk.abi.biguint_value import BigUIntValue
 from multiversx_sdk.abi.bool_value import BoolValue
 from multiversx_sdk.abi.bytes_value import BytesValue
@@ -298,7 +299,7 @@ def _create_prototype(self, type_formula: TypeFormula) -> Any:
         if name == "BigUint":
             return BigUIntValue()
         if name == "BigInt":
-            return BigUIntValue()
+            return BigIntValue()
         if name == "bytes":
             return BytesValue()
         if name == "utf-8 string":

diff --git a/multiversx_sdk/abi/abi_test.py b/multiversx_sdk/abi/abi_test.py
@@ -6,6 +6,7 @@
 from multiversx_sdk.abi.abi import Abi
 from multiversx_sdk.abi.abi_definition import AbiDefinition, ParameterDefinition
 from multiversx_sdk.abi.address_value import AddressValue
+from multiversx_sdk.abi.bigint_value import BigIntValue
 from multiversx_sdk.abi.biguint_value import BigUIntValue
 from multiversx_sdk.abi.bytes_value import BytesValue
 from multiversx_sdk.abi.counted_variadic_values import CountedVariadicValues
@@ -73,6 +74,9 @@ def test_abi_artificial():
     assert len(abi.definition.events) == 1
     assert abi.events_prototypes_by_name["firstEvent"].fields[0].value == BigUIntValue()
 
+    assert abi.endpoints_prototypes_by_name["black"].input_parameters == [BigIntValue()]
+    assert abi.endpoints_prototypes_by_name["black"].output_parameters == []
+
 
 def test_load_abi_with_counted_variadic():
     abi = Abi.load(testdata / "counted-variadic.abi.json")

diff --git a/multiversx_sdk/testutils/testdata/artificial.abi.json b/multiversx_sdk/testutils/testdata/artificial.abi.json
@@ -74,14 +74,27 @@
                 }
             ],
             "outputs": []
+        },
+        {
+            "name": "black",
+            "mutability": "mutable",
+            "inputs": [
+                {
+                    "name": "a",
+                    "type": "BigInt"
+                }
+            ],
+            "outputs": []
         }
     ],
     "types": {
         "OperationCompletionStatus": {
             "type": "explicit-enum",
             "variants": [
                 {
-                    "docs": ["indicates that operation was completed"],
+                    "docs": [
+                        "indicates that operation was completed"
+                    ],
                     "name": "completed"
                 },
                 {