Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed method parameter and fixed linter issue #110

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

popenta
Copy link
Collaborator

@popenta popenta commented Oct 17, 2024

Renamed a parameter:
From:

def decode_event(self, event_name: str, topics: List[bytes], data_items: List[bytes]) -> SimpleNamespace:

To:

def decode_event(self, event_name: str, topics: List[bytes], additional_data: List[bytes]) -> SimpleNamespace:

@popenta popenta self-assigned this Oct 17, 2024
Copy link

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  multiversx_sdk/abi
  abi.py 271
  multiversx_sdk/core/transactions_factories
  transfer_transactions_factory.py
  multiversx_sdk/core/transactions_outcome_parsers
  transaction_events_parser.py
  multiversx_sdk/network_providers
  transaction_decoder.py 15, 19
Project Total  

This report was generated by python-coverage-comment-action

@popenta popenta merged commit 22e21cd into feat/next Oct 17, 2024
6 checks passed
@popenta popenta deleted the renaming-and-fixes branch October 17, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants