Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing methods for token management controller #188

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

popenta
Copy link
Collaborator

@popenta popenta commented Jan 22, 2025

No description provided.

@popenta popenta self-assigned this Jan 22, 2025
Copy link

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  multiversx_sdk/token_management
  token_management_controller.py 926-940, 952-966, 977-988, 1004-1022, 1038-1056, 1067-1079, 1089-1101, 1114-1129, 1142-1157
Project Total  

This report was generated by python-coverage-comment-action

@@ -913,6 +913,249 @@ def await_completed_burn_quantity(self, transaction_hash: Union[str, bytes]) ->
transaction = self.network_provider.await_transaction_completed(transaction_hash)
return self.parse_burn_quantity(transaction)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the await completed and the parse methods are missing

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will be added in a future PR.

@popenta popenta merged commit 79a4441 into feat/next Jan 22, 2025
6 checks passed
@popenta popenta deleted the add-missing-methods-for-tx-management branch January 22, 2025 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants