Smart Contract deploy transactions parser #22
Conversation
| class SmartContractTransactionsOutcomeParser: | ||
| def __init__(self) -> None: |
There was a problem hiding this comment.
in specs there is alo parse_execute do we plan to implement it also?
There was a problem hiding this comment.
Yes, we'll implement that in the future. We need the abi for that but we currently don't have it in sdk-py.
| cryptography==36.0.2 | ||
| pycryptodomex==3.19.1 | ||
| protobuf==3.20.2 | ||
| cryptography==42.0.2 |
There was a problem hiding this comment.
No breaking changes that affect us, correct?
Let's triple-check here:
https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst
We should also adjust this workflow to include macos-latest and macos-13-xlarge (the latter is for MacOS ARM64):
https://github.com/multiversx/mx-sdk-py-incubator/blob/main/.github/workflows/test.yml#L16
The workflow adjustment can be done in a separate PR, though.
There was a problem hiding this comment.
Will take a look, and will also adjust the workflow in the next PR.
| @@ -111,6 +112,7 @@ def from_http_response( | |||
| result.gas_limit = response.get("gasLimit", 0) | |||
|
|
|||
| data = response.get("data", "") or "" | |||
| result.function = response.get("function", "") | |||
There was a problem hiding this comment.
| @@ -0,0 +1,16 @@ | |||
| from dataclasses import dataclass | |||
There was a problem hiding this comment.
Nice approach 👍 (*_types.py file for outcome parsers).
| assert actual_tx_outcome.logs.address == expected_tx_outcome.logs.address | ||
| assert actual_tx_outcome.logs.events[0].identifier == expected_tx_outcome.logs.events[0].identifier | ||
| assert actual_tx_outcome.logs.events[0].data_items == expected_tx_outcome.logs.events[0].data_items | ||
| assert actual_tx_outcome.logs.events[0].address == expected_tx_outcome.logs.events[0].address | ||
| assert actual_tx_outcome.logs.events[0].topics == expected_tx_outcome.logs.events[0].topics | ||
|
|
||
| assert actual_tx_outcome.transaction_results[0].sender == expected_tx_outcome.transaction_results[0].sender | ||
| assert actual_tx_outcome.transaction_results[0].receiver == expected_tx_outcome.transaction_results[0].receiver | ||
| assert actual_tx_outcome.transaction_results[0].data == expected_tx_outcome.transaction_results[0].data | ||
| assert actual_tx_outcome.transaction_results[0].logs.address == expected_tx_outcome.transaction_results[0].logs.address | ||
| assert actual_tx_outcome.transaction_results[0].logs.events[0].address == expected_tx_outcome.transaction_results[0].logs.events[0].address | ||
| assert actual_tx_outcome.transaction_results[0].logs.events[0].identifier == expected_tx_outcome.transaction_results[0].logs.events[0].identifier | ||
| assert actual_tx_outcome.transaction_results[0].logs.events[0].data_items == expected_tx_outcome.transaction_results[0].logs.events[0].data_items | ||
| assert actual_tx_outcome.transaction_results[0].logs.events[0].topics == expected_tx_outcome.transaction_results[0].logs.events[0].topics |
There was a problem hiding this comment.
No way to do a shorter assert? Deep equality etc.?
There was a problem hiding this comment.
No "native" way as far as I know. Will think about doing a custom deep_equal() method to use in some tests.
| owner_address_topic = event.topics[1] if event.topics[1] else b'' | ||
| code_hash_topic = event.topics[2] if event.topics[2] else b'' | ||
|
|
||
| contract_address = Address(contract_address_topic, DEFAULT_ADDRESS_HRP).to_bech32() if len(contract_address_topic) else "" |
There was a problem hiding this comment.
In the future, we have to parametrize such outcome parsers to receive the hrp.
There was a problem hiding this comment.
Indeed, I was thinking the same.
| assert len(parsed.contracts) == 0 | ||
| assert parsed.contracts == [] | ||
|
|
||
| @pytest.mark.networkInteraction |
| assert parsed.contracts[0].address == "erd1qqqqqqqqqqqqqpgq29deu3uhcvuk7jhxd5cxrvh23xulkcewd8ssyf38ec" | ||
| assert parsed.contracts[0].owner_address == "erd1qyu5wthldzr8wx5c9ucg8kjagg0jfs53s8nr3zpz3hypefsdd8ssycr6th" | ||
|
|
||
| @pytest.mark.networkInteraction |
Implemented the smart contract deploy transactions parser based on the sdk-specs.