Fixes and added a pyproject.toml file #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
popenta
commented
Jan 29, 2024
| allow-direct-references = true | ||
|
|
||
| [project] | ||
| name = "multiversx-sdk" |
There was a problem hiding this comment.
Question for reviewers: Perhaps it should be called simply multiversx?
There was a problem hiding this comment.
All right to contain the suffix SDK, I think. I'd vote to have the suffix.
There was a problem hiding this comment.
+1 with Andrei. sdk suffix should be fine
andreibancioiu
previously approved these changes
Jan 29, 2024
README.md
Outdated
| @@ -1,6 +1,6 @@ | |||
| # mx-sdk-py | |||
|
|
|||
| The Python SDK for interacting with MultiversX. | |||
| The Python SDK for interacting with MultiversX. It's an all in one sdk that can be used to create wallets, sign and broadcast transactions and many more. | |||
There was a problem hiding this comment.
Also - ... create transactions (including smart contract calls, deployments). Perhaps create wallets should be the last (not the main use case)?
There was a problem hiding this comment.
Rephrased it a little.
| allow-direct-references = true | ||
|
|
||
| [project] | ||
| name = "multiversx-sdk" |
There was a problem hiding this comment.
All right to contain the suffix SDK, I think. I'd vote to have the suffix.
| license = "MIT" | ||
| description = "The MultiversX Python SDK." | ||
| readme = "README.md" | ||
| requires-python = ">=3.8" |
There was a problem hiding this comment.
Should be all right 👍
andreibancioiu
previously approved these changes
Jan 30, 2024
This reverts commit ba6b0db.
andreibancioiu
approved these changes
Feb 1, 2024
ovidiuolteanu
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mainly import fixes and added a
pyproject.tomlfile.