Add a clearer panic message if settings.json is malformed #1939
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit aims to provide a clearer error message when attempting to install the available tools using the
sc-meta install all
command, in the rare case when a user has a malformed VSCode settings.json file.For example, let's consider these two settings.json file examples:
In the second case we have a trailling comma, after the end of the editor.defaultFormatter row. While this additional comma won't be a problem for VSCode to parse the settings file, this is inherently a malformed json, if we verify it with any online linter. This, in turn, will cause problems for serde. The fix is to just instruct the user to perform a lint check of its settings file, and then proceed with the installation.