Skip to content

Execute ops

Execute ops #153

Triggered via pull request March 17, 2024 11:10
Status Failure
Total duration 5m 37s
Artifacts

actions.yml

on: pull_request
Contracts  /  Wasm tests
5m 27s
Contracts / Wasm tests
Contracts  /  Rust tests
1m 0s
Contracts / Rust tests
Contracts  /  Clippy linter check
19s
Contracts / Clippy linter check
Fit to window
Zoom out
Zoom in

Annotations

6 errors and 15 warnings
Contracts / Rust tests: esdt-safe/tests/bridge_test.rs#L275
no method named `batch_transfer_esdt_token` found for struct `esdt_safe::ContractObj` in the current scope
Contracts / Rust tests: esdt-safe/tests/bridge_test.rs#L339
no method named `batch_transfer_esdt_token` found for struct `esdt_safe::ContractObj` in the current scope
Contracts / Rust tests
Process completed with exit code 101.
Contracts / Wasm tests: esdt-safe/tests/bridge_test.rs#L275
no method named `batch_transfer_esdt_token` found for struct `esdt_safe::ContractObj` in the current scope
Contracts / Wasm tests: esdt-safe/tests/bridge_test.rs#L339
no method named `batch_transfer_esdt_token` found for struct `esdt_safe::ContractObj` in the current scope
Contracts / Wasm tests
Process completed with exit code 101.
[clippy] common/transaction/src/lib.rs#L71: common/transaction/src/lib.rs#L71
warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true --> common/transaction/src/lib.rs:71:1 | 71 | impl<M: ManagedTypeApi> Into<EsdtTokenPayment<M>> for OperationEsdtPayment<M> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: `impl From<Local> for Foreign` is allowed by the orphan rules, for more information see https://doc.rust-lang.org/reference/items/implementations.html#trait-implementation-coherence = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into = note: `#[warn(clippy::from_over_into)]` on by default help: replace the `Into` implementation with `From<OperationEsdtPayment<M>>` | 71 ~ impl<M: ManagedTypeApi> From<OperationEsdtPayment<M>> for EsdtTokenPayment<M> { 72 ~ fn from(val: OperationEsdtPayment<M>) -> Self { 73 | EsdtTokenPayment { 74 ~ token_identifier: val.token_identifier, 75 ~ token_nonce: val.token_nonce, 76 ~ amount: val.token_data.amount, |
[clippy] common/transaction/src/lib.rs#L129: common/transaction/src/lib.rs#L129
warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true --> common/transaction/src/lib.rs:129:1 | 129 | impl<M: ManagedTypeApi> Into<EsdtTokenData<M>> for StolenFromFrameworkEsdtTokenData<M> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: `impl From<Local> for Foreign` is allowed by the orphan rules, for more information see https://doc.rust-lang.org/reference/items/implementations.html#trait-implementation-coherence = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into help: replace the `Into` implementation with `From<StolenFromFrameworkEsdtTokenData<M>>` | 129 ~ impl<M: ManagedTypeApi> From<StolenFromFrameworkEsdtTokenData<M>> for EsdtTokenData<M> { 130 ~ fn from(val: StolenFromFrameworkEsdtTokenData<M>) -> Self { 131 | EsdtTokenData { 132 ~ token_type: val.token_type, 133 ~ amount: val.amount, 134 ~ frozen: val.frozen, 135 ~ hash: val.hash, 136 ~ name: val.name, 137 ~ attributes: val.attributes, 138 ~ creator: val.creator, 139 ~ royalties: val.royalties, 140 ~ uris: val.uris, |
[clippy] common/transaction/src/lib.rs#L71: common/transaction/src/lib.rs#L71
warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true --> common/transaction/src/lib.rs:71:1 | 71 | impl<M: ManagedTypeApi> Into<EsdtTokenPayment<M>> for OperationEsdtPayment<M> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: `impl From<Local> for Foreign` is allowed by the orphan rules, for more information see https://doc.rust-lang.org/reference/items/implementations.html#trait-implementation-coherence = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into = note: `#[warn(clippy::from_over_into)]` on by default help: replace the `Into` implementation with `From<OperationEsdtPayment<M>>` | 71 ~ impl<M: ManagedTypeApi> From<OperationEsdtPayment<M>> for EsdtTokenPayment<M> { 72 ~ fn from(val: OperationEsdtPayment<M>) -> Self { 73 | EsdtTokenPayment { 74 ~ token_identifier: val.token_identifier, 75 ~ token_nonce: val.token_nonce, 76 ~ amount: val.token_data.amount, |
[clippy] common/transaction/src/lib.rs#L129: common/transaction/src/lib.rs#L129
warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true --> common/transaction/src/lib.rs:129:1 | 129 | impl<M: ManagedTypeApi> Into<EsdtTokenData<M>> for StolenFromFrameworkEsdtTokenData<M> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: `impl From<Local> for Foreign` is allowed by the orphan rules, for more information see https://doc.rust-lang.org/reference/items/implementations.html#trait-implementation-coherence = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into help: replace the `Into` implementation with `From<StolenFromFrameworkEsdtTokenData<M>>` | 129 ~ impl<M: ManagedTypeApi> From<StolenFromFrameworkEsdtTokenData<M>> for EsdtTokenData<M> { 130 ~ fn from(val: StolenFromFrameworkEsdtTokenData<M>) -> Self { 131 | EsdtTokenData { 132 ~ token_type: val.token_type, 133 ~ amount: val.amount, 134 ~ frozen: val.frozen, 135 ~ hash: val.hash, 136 ~ name: val.name, 137 ~ attributes: val.attributes, 138 ~ creator: val.creator, 139 ~ royalties: val.royalties, 140 ~ uris: val.uris, |
[clippy] esdt-safe/src/from_sovereign/token_mapping.rs#L32: esdt-safe/src/from_sovereign/token_mapping.rs#L32
warning: this creates an owned instance just for comparison --> esdt-safe/src/from_sovereign/token_mapping.rs:32:27 | 32 | issue_cost == BigUint::from(DEFAULT_ISSUE_COST), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `DEFAULT_ISSUE_COST` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned = note: `#[warn(clippy::cmp_owned)]` on by default
[clippy] esdt-safe/src/from_sovereign/token_mapping.rs#L32: esdt-safe/src/from_sovereign/token_mapping.rs#L32
warning: this creates an owned instance just for comparison --> esdt-safe/src/from_sovereign/token_mapping.rs:32:27 | 32 | issue_cost == BigUint::from(DEFAULT_ISSUE_COST), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `DEFAULT_ISSUE_COST` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned = note: `#[warn(clippy::cmp_owned)]` on by default
[clippy] esdt-safe/src/to_sovereign/create_tx.rs#L190: esdt-safe/src/to_sovereign/create_tx.rs#L190
warning: length comparison to zero --> esdt-safe/src/to_sovereign/create_tx.rs:190:16 | 190 | if self.token_whitelist().len() > 0 | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!self.token_whitelist().is_empty()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero = note: `#[warn(clippy::len_zero)]` on by default
[clippy] esdt-safe/src/to_sovereign/create_tx.rs#L265: esdt-safe/src/to_sovereign/create_tx.rs#L265
warning: using `clone` on type `u64` which implements the `Copy` trait --> esdt-safe/src/to_sovereign/create_tx.rs:265:29 | 265 | ... transfer_data.gas_limit.clone(), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `transfer_data.gas_limit` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy = note: `#[warn(clippy::clone_on_copy)]` on by default
[clippy] esdt-safe/src/to_sovereign/create_tx.rs#L190: esdt-safe/src/to_sovereign/create_tx.rs#L190
warning: length comparison to zero --> esdt-safe/src/to_sovereign/create_tx.rs:190:16 | 190 | if self.token_whitelist().len() > 0 | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!self.token_whitelist().is_empty()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero = note: `#[warn(clippy::len_zero)]` on by default
[clippy] esdt-safe/src/to_sovereign/create_tx.rs#L265: esdt-safe/src/to_sovereign/create_tx.rs#L265
warning: using `clone` on type `u64` which implements the `Copy` trait --> esdt-safe/src/to_sovereign/create_tx.rs:265:29 | 265 | ... transfer_data.gas_limit.clone(), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `transfer_data.gas_limit` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy = note: `#[warn(clippy::clone_on_copy)]` on by default
Contracts / Clippy linter check
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, giraffate/clippy-action@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Contracts / Rust tests
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Contracts / Rust tests: esdt-safe/tests/bridge_test.rs#L9
unused import: `from_sovereign::transfer_tokens::TransferTokensModule`
Contracts / Wasm tests
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Contracts / Wasm tests: esdt-safe/tests/bridge_test.rs#L9
unused import: `from_sovereign::transfer_tokens::TransferTokensModule`