Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enshrine configuration struct #213

Merged
merged 19 commits into from
Jan 9, 2025
Merged

Enshrine configuration struct #213

merged 19 commits into from
Jan 9, 2025

Conversation

andreiblt1304
Copy link
Contributor

No description provided.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 2, 2025 •
edited
Loading

Coverage Summary

Totals

Count Covered %
Lines 8114 4551 56.09
Regions 2046 828 40.47
Functions 818 402 49.14
Instantiations 3424 835 24.39

Files

Expand
File Lines Regions Functions Instantiations
/chain-config/meta/src/main.rs 0.00% 0.00% 0.00% 0.00%
/chain-config/src/lib.rs 38.30% 27.27% 50.00% 25.00%
/chain-config/src/validator_rules.rs 16.00% 21.74% 44.44% 18.07%
/chain-factory/meta/src/main.rs 0.00% 0.00% 0.00% 0.00%
/chain-factory/src/complete_phases.rs 0.00% 0.00% 0.00% 0.00%
/chain-factory/src/factory.rs 80.43% 75.00% 83.33% 27.27%
/chain-factory/src/lib.rs 100.00% 100.00% 100.00% 32.61%
/chain-factory/tests/chain_factory_tests.rs 99.08% 81.82% 100.00% 100.00%
/common/interactor/src/interactor_config.rs 0.00% 0.00% 0.00% 0.00%
/common/interactor/src/interactor_state.rs 0.00% 0.00% 0.00% 0.00%
/common/max-bridged-amount-module/src/lib.rs 76.92% 62.50% 75.00% 18.18%
/common/operation/src/lib.rs 77.19% 47.45% 56.06% 36.10%
/common/proxies/src/chain_config_proxy.rs 20.77% 7.14% 10.53% 20.51%
/common/proxies/src/chain_factory_proxy.rs 50.56% 46.15% 46.15% 43.33%
/common/proxies/src/enshrine_esdt_safe_proxy.rs 49.12% 45.00% 45.00% 21.28%
/common/proxies/src/esdt_safe_proxy.rs 31.93% 33.33% 33.33% 26.42%
/common/proxies/src/fee_market_proxy.rs 50.00% 25.00% 36.00% 28.26%
/common/proxies/src/header_verifier_proxy.rs 82.42% 75.00% 75.00% 47.46%
/common/proxies/src/sovereign_forge_proxy.rs 69.43% 64.29% 64.29% 23.26%
/common/proxies/src/testing_sc_proxy.rs 0.00% 0.00% 0.00% 0.00%
/common/proxies/src/token_handler_proxy.rs 45.83% 44.44% 44.44% 50.00%
/common/setup-phase/src/lib.rs 100.00% 83.33% 100.00% 11.69%
/common/token-whitelist/src/lib.rs 26.67% 31.25% 50.00% 12.50%
/common/tx-batch-module/src/lib.rs 100.00% 83.33% 100.00% 28.57%
/common/utils/src/lib.rs 81.25% 67.74% 80.00% 21.88%
/enshrine-esdt-safe/interactor/src/enshrine_esdt_safe_interactor.rs 0.00% 0.00% 0.00% 0.00%
/enshrine-esdt-safe/interactor/src/enshrine_esdt_safe_interactor_main.rs 0.00% 0.00% 0.00% 0.00%
/enshrine-esdt-safe/interactor/tests/enshrine-esdt-safe_interactor_tests.rs 0.00% 0.00% 0.00% 0.00%
/enshrine-esdt-safe/meta/src/main.rs 0.00% 0.00% 0.00% 0.00%
/enshrine-esdt-safe/src/common/storage.rs 100.00% 66.67% 100.00% 35.71%
/enshrine-esdt-safe/src/from_sovereign/events.rs 100.00% 66.67% 100.00% 16.67%
/enshrine-esdt-safe/src/from_sovereign/transfer_tokens.rs 90.08% 82.35% 83.33% 30.77%
/enshrine-esdt-safe/src/lib.rs 86.11% 75.00% 80.00% 18.75%
/enshrine-esdt-safe/src/to_sovereign/create_tx.rs 95.41% 93.75% 100.00% 30.77%
/enshrine-esdt-safe/src/to_sovereign/events.rs 100.00% 66.67% 100.00% 16.67%
/enshrine-esdt-safe/tests/enshrine_esdt_safe_blackbox_test.rs 99.88% 97.26% 100.00% 100.00%
/esdt-safe/interactor/src/esdt_safe_interactor.rs 0.00% 0.00% 0.00% 0.00%
/esdt-safe/interactor/src/esdt_safe_interactor_main.rs 0.00% 0.00% 0.00% 0.00%
/esdt-safe/interactor/tests/esdt_safe_interactor_tests.rs 0.00% 0.00% 0.00% 0.00%
/esdt-safe/meta/src/main.rs 0.00% 0.00% 0.00% 0.00%
/esdt-safe/src/from_sovereign/events.rs 100.00% 66.67% 100.00% 12.50%
/esdt-safe/src/from_sovereign/token_mapping.rs 1.10% 5.41% 5.26% 5.21%
/esdt-safe/src/from_sovereign/transfer_tokens.rs 41.63% 50.00% 75.00% 22.39%
/esdt-safe/src/lib.rs 76.47% 75.00% 66.67% 22.86%
/esdt-safe/src/to_sovereign/create_tx.rs 45.51% 50.94% 62.50% 20.41%
/esdt-safe/src/to_sovereign/events.rs 100.00% 66.67% 100.00% 12.50%
/esdt-safe/tests/bridge_blackbox_tests.rs 86.16% 92.86% 91.67% 91.67%
/fee-market/meta/src/main.rs 0.00% 0.00% 0.00% 0.00%
/fee-market/src/fee_common.rs 100.00% 75.00% 100.00% 27.59%
/fee-market/src/fee_type.rs 85.29% 53.66% 64.29% 25.74%
/fee-market/src/lib.rs 28.57% 54.55% 50.00% 29.85%
/fee-market/src/price_aggregator.rs 0.00% 0.00% 0.00% 0.00%
/fee-market/src/subtract_fee.rs 42.86% 37.50% 43.75% 14.67%
/fee-market/tests/fee_market_blackbox_test.rs 93.33% 89.58% 100.00% 100.00%
/header-verifier/meta/src/main.rs 0.00% 0.00% 0.00% 0.00%
/header-verifier/src/lib.rs 74.74% 77.50% 84.62% 43.27%
/header-verifier/tests/header_verifier_blackbox_test.rs 100.00% 100.00% 100.00% 100.00%
/sovereign-forge/interactor/src/config.rs 0.00% 0.00% 0.00% 0.00%
/sovereign-forge/interactor/src/interact.rs 0.00% 0.00% 0.00% 0.00%
/sovereign-forge/interactor/src/interactor_main.rs 0.00% 0.00% 0.00% 0.00%
/sovereign-forge/interactor/tests/interact_cs_tests.rs 0.00% 0.00% 0.00% 0.00%
/sovereign-forge/interactor/tests/interact_tests.rs 0.00% 0.00% 0.00% 0.00%
/sovereign-forge/meta/src/main.rs 0.00% 0.00% 0.00% 0.00%
/sovereign-forge/src/common/sc_deploy.rs 97.06% 57.14% 80.00% 22.22%
/sovereign-forge/src/common/storage.rs 100.00% 33.33% 100.00% 15.79%
/sovereign-forge/src/common/utils.rs 89.02% 56.36% 66.67% 29.69%
/sovereign-forge/src/lib.rs 100.00% 100.00% 100.00% 23.26%
/sovereign-forge/src/phases.rs 99.00% 90.00% 100.00% 27.50%
/sovereign-forge/tests/sovereign_forge_unit_tests.rs 99.71% 95.65% 100.00% 100.00%
/testing-sc/meta/src/main.rs 0.00% 0.00% 0.00% 0.00%
/testing-sc/src/lib.rs 0.00% 0.00% 0.00% 0.00%
/token-handler/meta/src/main.rs 0.00% 0.00% 0.00% 0.00%
/token-handler/src/common_storage.rs 100.00% 50.00% 100.00% 21.05%
/token-handler/src/lib.rs 100.00% 100.00% 100.00% 30.43%
/token-handler/src/transfer_tokens.rs 50.52% 36.67% 66.67% 30.30%
/token-handler/tests/token_handler_blackbox_tests.rs 94.62% 95.65% 100.00% 100.00%

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 2, 2025 •
edited
Loading

Contract comparison - from 5ecbc27 to 45dac79

Path                                                                                             size                  has-allocator                     has-format
chain-config-full.wasm 4761 false without message
chain-config-view.wasm 626 false None
chain-config.wasm 4761 false without message
enshrine-esdt-safe-full.wasm 21879 ➡️ 22945 🔴 false without message
enshrine-esdt-safe-view.wasm 626 false None
enshrine-esdt-safe.wasm 21878 ➡️ 22944 🔴 false without message
esdt-safe.wasm 22938 false without message
esdt-safe-view.wasm 626 false None
esdt-safe-full.wasm 22938 false without message
testing-sc.wasm 461 false None
testing-view.wasm 626 false None
testing-sc-full.wasm 461 false None
fee-market.wasm 11570 false without message
fee-market-view.wasm 626 false None
soveriegn-forge-view.wasm 626 false None
sovereign-forge-full.wasm 9264 false without message
sovereign-forge.wasm 9264 false without message
chain-factory-full.wasm 7364 ➡️ 8283 🔴 false without message
chain-factory-view.wasm 626 false None
chain-factory.wasm 7364 ➡️ 8283 🔴 false without message
header-verifier-full.wasm 5678 false without message
header-verifier.wasm 5678 false without message
multisig-view.wasm 626 false None
token-handler-view.wasm 626 false None
token-handler-full.wasm 9359 false without message
token-handler.wasm 9359 false without message

axenteoctavian
axenteoctavian requested changes Jan 8, 2025
View reviewed changes
common/transaction/src/lib.rs Outdated Show resolved Hide resolved
common/transaction/src/lib.rs Outdated Show resolved Hide resolved
enshrine-esdt-safe/src/lib.rs Outdated Show resolved Hide resolved
enshrine-esdt-safe/src/lib.rs Outdated Show resolved Hide resolved
enshrine-esdt-safe/src/common/storage.rs Outdated Show resolved Hide resolved
enshrine-esdt-safe/src/common/storage.rs
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also refactor /common/token-whitelist module. Delete unused functions and storages. The rest of the functions you can move them in a utils module in enshrine-esdt-safe/src/common/utils.rs

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will do in a different PR

@andreiblt1304
Fixed merging errors
031e527 
Signed-off-by: Andrei Baltariu <[email protected]>
@andreiblt1304
Renamed function and added constant for max tx gas limit
3b50e98 
Signed-off-by: Andrei Baltariu <[email protected]>
@andreiblt1304
Added optional value for BridgeConfig in init
c9295e6 
Signed-off-by: Andrei Baltariu <[email protected]>
@andreiblt1304
Removed require inside update_configuration endpoint
7a305f2 
Signed-off-by: Andrei Baltariu <[email protected]>
@andreiblt1304
Removed unused storage mappers
2c993d2 
Signed-off-by: Andrei Baltariu <[email protected]>
@andreiblt1304
Removed uses of old mappers
92248f2 
Signed-off-by: Andrei Baltariu <[email protected]>
@andreiblt1304
Added new function for BridgeConfig struct
3d25788 
Signed-off-by: Andrei Baltariu <[email protected]>
@andreiblt1304
Added optional parameter for endpoint
8ee18f1 
Signed-off-by: Andrei Baltariu <[email protected]>
@andreiblt1304
Fixed failing tests
06c17a3 
Signed-off-by: Andrei Baltariu <[email protected]>
@andreiblt1304
Clippy fix
4a761a5 
Signed-off-by: Andrei Baltariu <[email protected]>
@andreiblt1304 andreiblt1304 merged commit d95baf7 into feat/beta Jan 9, 2025
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CostinCarabas CostinCarabas CostinCarabas approved these changes

@axenteoctavian axenteoctavian axenteoctavian approved these changes

@sergiuosvat sergiuosvat sergiuosvat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andreiblt1304 @CostinCarabas @axenteoctavian @sergiuosvat